Page MenuHomePhabricator
Create Task
Maniphest T5979

Board drop target position is computed incorrectly after scrolling
Closed, ResolvedPublic
Actions

Description

When dragging a task in a workboard scrolling the page (with mouse wheel or arrow keys for example) causes the drop position of the task to be incorrectly calculated and displayed.

This can be recreated by creating a workboard with a large enough number of tasks to scroll a couple of pages in height. Dragging and then using the mouse wheel or arrow keys to scroll the page will cause the shown new position of the task to lie away from the actual location of the mouse and dragged task. The more that is scrolled the larger the gap between intended drop location and actual.

I have recreated this in both Chrome and Firefox.

Revisions and Commits

rP Phabricator
D10455rPf02aed10e769 Fix three issues with scrolling while dragging items (e.g., on workboards)
D10416rPaaa08edb1251 When users scroll while dragging items, update item positions immediately

Event Timeline

• cpa199 created this task.Aug 27 2014, 3:26 PM
• cpa199 raised the priority of this task from to Needs Triage.
• cpa199 updated the task description. (Show Details)
• cpa199 added a project: Workboards.
• cpa199 added a subscriber: • cpa199.
epriestley added a subscriber: epriestley.Aug 27 2014, 3:37 PM

Are you up to date? D10186 was supposed to fix this.

• cpa199 added a comment.Aug 27 2014, 3:45 PM

I've just done a pull on all 3 projects (of course shutting down apache and phd daemons prior to doing this) and I did get some updates, however it unfortunately didn't fix the issue and I didn't originally install it more than a week ago which looks like it was after this fix.
I will restart the entire server when I can just to make doubly sure I've not missed something but currently it looks in my case like it is still happening.

epriestley added a comment.Aug 27 2014, 3:47 PM

Okay, I'll see if I can reproduce this. Maybe I didn't test D10186 properly.

chad triaged this task as Normal priority.Sep 2 2014, 5:30 PM
chad added a subscriber: chad.

I can sorta reproduce this, if you grab a card, and use the scroll wheel only, the position does not recalculate until the mouse moves. Once you mouse move, the position updates.

epriestley claimed this task.Sep 4 2014, 6:04 PM
epriestley added a revision: D10416: When users scroll while dragging items, update item positions immediately.Sep 4 2014, 6:13 PM
epriestley added a comment.Sep 4 2014, 6:19 PM

D10416 fixes the jumpiness when scrolling. I can't reproduce the original issue, per se, exactly as described -- works fine for me in both Firefox and Chrome.

• cpa199 added a comment.Sep 4 2014, 6:28 PM

I'm going to do another installation from latest source, I suspect I must have made a mistake if you can't reproduce. I'll do it when I get into work tomorrow.

epriestley closed this task as Resolved.Sep 4 2014, 7:48 PM
epriestley added a commit: rPaaa08edb1251: When users scroll while dragging items, update item positions immediately.

Closed by commit rPaaa08edb1251.

• cpa199 added a comment.Sep 5 2014, 9:58 AM

I have updated to the most recent code, checked I've got the changes by comparing to the diffs linked above, however I can still fully replicate this issue.
I've loaded the javascript for DraggableList.js in my browser and ensured it has the changes you've made (to ensure there is no hidden caching), turned off entirely any browser caching but I still have the issue.
I'm willing to believe I've done something wrong but I'm afraid I'm running out of things that it could be.

• cpa199 reopened this task as Open.EditedSep 5 2014, 10:01 AM

I've reopened it as either there is something that I'm missing or this issue still exists. I'm happy to provide you any more information you need but for me this makes the workboards pretty unusable once they have a realistic amount of work in.

I've attached a video of the behaviour too, which also shows a couple of the js files that were changed in the diffs you've linked and you can see the changes are there.
{F199425}

epriestley added a comment.Sep 5 2014, 11:28 AM

Hmm, I don't seem to be able to play that video in any program on my system.

What OS are you using?

• cpa199 added a comment.Sep 5 2014, 11:31 AM

It's a windows video as that was the quickest way for me to record. It's
actually running in an Ubuntu VM however screen cap in VM seems to just
record a black screen. I'll try and find a working video capture app that
will record mp4 or something and re-upload.

epriestley added a comment.Sep 5 2014, 11:31 AM

Here's what I see locally on Chrome in OSX :

• cpa199 added a comment.Sep 5 2014, 11:38 AM

Here is an mp4, and you'll see the difference compared to your video. I'm dragging up and down in a long list of a single column.

epriestley renamed this task from Scrolling the page while dragging a task on a workboard causes the new position of the task to be incorrect. to Calculation of aggregate scroll offset incorrect in Ubuntu.Sep 5 2014, 11:42 AM
• cpa199 added a comment.Sep 5 2014, 11:53 AM

This is not Ubuntu specific, I just tried this on Windows in Chrome and have the exact same issue.

epriestley renamed this task from Calculation of aggregate scroll offset incorrect in Ubuntu to Calculation of aggregate scroll offset incorrect on non-OSX OSes.Sep 5 2014, 11:58 AM
epriestley added a comment.Sep 5 2014, 3:54 PM

Sorry, I got this wrong. The issue reproduces for me. I was fixated on the "ghost" behavior because we changed it recently and D10186 fixed a real bug with it, and it took a while for it to sink in after watching your video.

epriestley renamed this task from Calculation of aggregate scroll offset incorrect on non-OSX OSes to Board drop target position is computed incorrectly after scrolling.Sep 5 2014, 3:54 PM
• cpa199 added a comment.Sep 5 2014, 3:55 PM

No worries, just glad you've been able to reproduce it and I wasn't going
mad!

epriestley added a revision: D10455: Fix three issues with scrolling while dragging items (e.g., on workboards).Sep 9 2014, 8:53 PM
epriestley closed this task as Resolved.Sep 9 2014, 9:20 PM
epriestley added a commit: rPf02aed10e769: Fix three issues with scrolling while dragging items (e.g., on workboards).

Closed by commit rPf02aed10e769.

epriestley added a comment.Sep 9 2014, 9:24 PM

Let me know if you're still seeing issues after that, this drag-and-drop stuff is a bit finicky.

• cpa199 added a comment.Sep 10 2014, 1:57 PM

That seems to have fixed the issue nicely. Thanks a lot :)

Phabricator · Built by Phacility