Differential D20627

Remove property "id" from Workboard View controller
ClosedPublic
Actions

Authored by epriestley on Jun 29 2019, 9:20 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T4900: Workboards updating in real time

Commits

rP0ae9e2c75d1f: Remove property "id" from Workboard View controller

Summary

Depends on D20626. Ref T4900. On this controller, "id" is a separate property, but serves little purpose and complicates separating state management. Remove it.

Test Plan

Bulk edited a column, managed filters, did show/hide on columns, edited a column.

Diff Detail

Repository

rP Phabricator

Branch

refresh2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23077
Build 31680: Run Core Tests
Build 31679: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 29 2019, 9:20 PM

Harbormaster completed remote builds in B23077: Diff 49208.Jun 29 2019, 9:22 PM

epriestley requested review of this revision.Jun 29 2019, 9:22 PM

amckinley accepted this revision.Jun 29 2019, 9:26 PM

This revision is now accepted and ready to land.Jun 29 2019, 9:26 PM

epriestley added a child revision: D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.Jun 29 2019, 10:11 PM

Closed by commit rP0ae9e2c75d1f: Remove property "id" from Workboard View controller (authored by epriestley). · Explain WhyJul 2 2019, 12:17 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0ae9e2c75d1f: Remove property "id" from Workboard View controller.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

10 lines

Diff 49208

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Remove property "id" from Workboard View controllerClosedPublicActions