Differential D20409

Make "Move Panel" on dashboards use the new storage and transactions
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 7:09 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPfb994909cf9c: Make "Move Panel" on dashboards use the new storage and transactions

Summary

Depends on D20408. Ref T13272. The actual JS is still a little bit iffy, but this makes the server side "move" operation work correctly by updating it to use the same code as everything else.

Test Plan

Moved panels around on single-column and multi-column dashboards, saw them move to reasonable places and stay there when I reloaded the page.

Diff Detail

Repository

rP Phabricator

Branch

panel11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22570
Build 30913: Run Core Tests
Build 30912: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2019, 7:09 PM

Harbormaster completed remote builds in B22570: Diff 48700.Apr 12 2019, 7:11 PM

epriestley requested review of this revision.Apr 12 2019, 7:11 PM

epriestley added a child revision: D20410: Remove legacy "DashboardInstall" table.Apr 12 2019, 7:24 PM

amckinley accepted this revision.Apr 12 2019, 8:41 PM

amckinley added inline comments.

webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
45	Not sure if you'd consider this a whitespace-only change detection bug or not, since we're just moving the brace from line 70 up.

This revision is now accepted and ready to land.Apr 12 2019, 8:41 PM

epriestley added inline comments.Apr 12 2019, 9:32 PM

webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
46	I think the rendering is reasonable -- this is the brace from line 70. The brace on line 47/45 moved in, arguably? How would you expect/prefer this be rendered?