Page MenuHomePhabricator

Modularize dashboard layout modes (one column, two columns, etc)
ClosedPublic

Authored by epriestley on Apr 12 2019, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 5, 9:32 AM
Unknown Object (File)
Sat, May 4, 7:58 PM
Unknown Object (File)
Wed, May 1, 12:14 AM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Thu, Apr 11, 9:30 AM
Unknown Object (File)
Apr 1 2024, 7:40 AM
Unknown Object (File)
Mar 27 2024, 1:55 AM
Unknown Object (File)
Mar 27 2024, 1:55 AM
Subscribers
None

Details

Summary

Depends on D20405. Ref T13272. Currently, the PhabricatorDashboardLayoutConfig class uses a lot of switch() statements to define layout modes.

Although I'm not planning to add thousands of new layout modes, this (and upcoming changes) can be made substantially cleaner by using a standard modular approach.

(This doesn't fully remove PhabricatorDashboardLayoutConfig yet, but that will happen soon.)

Test Plan

Edited a dashboard, saw the same layout modes as before.

Diff Detail

Repository
rP Phabricator
Branch
panel8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22566
Build 30906: Run Core Tests
Build 30905: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/dashboard/layoutconfig/PhabricatorDashboardOneThirdLayoutMode.php
13

What about the final 1%?

/s

This revision is now accepted and ready to land.Apr 12 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.