Page MenuHomePhabricator
Differential D20122

On login forms, autofocus the "username" field
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 4:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 9:22 PM
Unknown Object (File)
Feb 18 2025, 12:33 PM
Unknown Object (File)
Feb 17 2025, 11:23 AM
Unknown Object (File)
Feb 9 2025, 7:08 AM
Unknown Object (File)
Feb 9 2025, 7:08 AM
Unknown Object (File)
Feb 9 2025, 7:08 AM
Unknown Object (File)
Feb 9 2025, 7:08 AM
Unknown Object (File)
Jan 28 2025, 8:32 AM
View All Files
Subscribers
None
Tokens
"100" token, awarded by amckinley."Dat Boi" token, awarded by cspeckmim.

Details

Reviewers
amckinley
Maniphest Tasks
T8907: Auto-focus first login field on login page
Commits
rP949afb02fd19: On login forms, autofocus the "username" field
Summary

Depends on D20120. Fixes T8907. I thought this needed some Javascript nonsense but Safari, Firefox and Chrome all support an autofocus attribute.

Test Plan

Loaded login page with password auth enabled in Safari, Firefox, and Chrome; saw username field automatically gain focus.

Diff Detail

Repository
rP Phabricator
Branch
xacc11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21877
Build 29863: Run Core Tests
Build 29862: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
provider/
1 line
1 line
view/
form/
control/
11 lines

Diff 48037

View Options

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorPasswordAuthProvider.php

Loading...
View Options

src/view/form/control/AphrontFormTextControl.php

Loading...
Phabricator · Built by Phacility