Page MenuHomePhabricator
Differential D20122

On login forms, autofocus the "username" field
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 4:55 AM.
Tags
None
Referenced Files
F14097486: D20122.diff
Tue, Nov 26, 7:10 AM
F14094138: D20122.diff
Mon, Nov 25, 2:32 PM
Unknown Object (File)
Thu, Nov 21, 3:51 PM
Unknown Object (File)
Sun, Nov 17, 8:00 AM
Unknown Object (File)
Mon, Nov 4, 10:42 AM
Unknown Object (File)
Mon, Nov 4, 10:42 AM
Unknown Object (File)
Mon, Nov 4, 10:41 AM
Unknown Object (File)
Sun, Nov 3, 1:56 AM
View All Files
Subscribers
None
Tokens
"100" token, awarded by amckinley."Dat Boi" token, awarded by cspeckmim.

Details

Reviewers
amckinley
Maniphest Tasks
T8907: Auto-focus first login field on login page
Commits
rP949afb02fd19: On login forms, autofocus the "username" field
Summary

Depends on D20120. Fixes T8907. I thought this needed some Javascript nonsense but Safari, Firefox and Chrome all support an autofocus attribute.

Test Plan

Loaded login page with password auth enabled in Safari, Firefox, and Chrome; saw username field automatically gain focus.

Diff Detail

Repository
rP Phabricator
Branch
xacc11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21877
Build 29863: Run Core Tests
Build 29862: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
provider/
1 line
1 line
view/
form/
control/
11 lines

Diff 48037

View Options

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorPasswordAuthProvider.php

Loading...
View Options

src/view/form/control/AphrontFormTextControl.php

Loading...
Phabricator · Built by Phacility