Differential D20128

Autofocus form control for adding TOTP codes
ClosedPublic
Actions

Authored by amckinley on Feb 7 2019, 7:37 PM.

Tags

None

Referenced Files

	F15451859: D20128.id48050.diff
	Sat, Mar 29, 12:10 AM

	F15451164: D20128.id48050.diff
	Fri, Mar 28, 8:33 PM

	F15449361: D20128.id48048.diff
	Fri, Mar 28, 9:42 AM

	F15446528: D20128.id.diff
	Thu, Mar 27, 7:27 PM

	F15439916: D20128.diff
	Wed, Mar 26, 10:13 AM

	F15399153: D20128.id48050.diff
	Mon, Mar 17, 3:07 AM

	F15391660: D20128.id48048.diff
	Sat, Mar 15, 10:54 AM

	F15338334: D20128.diff
	Sun, Mar 9, 10:30 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPf2236eb061a6: Autofocus form control for adding TOTP codes

Summary

Ref D20122. This is something I wanted in a bunch of places. Looks like at some point the most-annoying one (autofocus for entering TOTOP codes) already got fixed at some point.

Test Plan

Loaded the form, got autofocus as expected.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Feb 7 2019, 7:37 PM

Harbormaster completed remote builds in B21885: Diff 48048.Feb 7 2019, 7:39 PM

amckinley requested review of this revision.Feb 7 2019, 7:39 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 7 2019, 7:39 PM

When forms load in an Ajax dialog, I think we autofocus the first input, but don't do that if dialogs load on standalone pages. I don't think this can hurt, at least.

This revision is now accepted and ready to land.Feb 7 2019, 7:48 PM

Closed by commit rPf2236eb061a6: Autofocus form control for adding TOTP codes (authored by amckinley). · Explain WhyFeb 7 2019, 7:56 PM

This revision was automatically updated to reflect the committed changes.