Page MenuHomePhabricator

Autofocus form control for adding TOTP codes
ClosedPublic

Authored by amckinley on Thu, Feb 7, 7:37 PM.

Details

Summary

Ref D20122. This is something I wanted in a bunch of places. Looks like at some point the most-annoying one (autofocus for entering TOTOP codes) already got fixed at some point.

Test Plan

Loaded the form, got autofocus as expected.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Thu, Feb 7, 7:37 PM
amckinley requested review of this revision.Thu, Feb 7, 7:39 PM
epriestley accepted this revision.Thu, Feb 7, 7:48 PM

When forms load in an Ajax dialog, I think we autofocus the first input, but don't do that if dialogs load on standalone pages. I don't think this can hurt, at least.

This revision is now accepted and ready to land.Thu, Feb 7, 7:48 PM
This revision was automatically updated to reflect the committed changes.