Page MenuHomePhabricator

Allow users to be approved from the profile "Manage" page, alongside other similar actions
ClosedPublic

Authored by epriestley on Feb 7 2019, 3:08 PM.

Details

Summary

Depends on D20122. Fixes T8029. Adds an "Approve User" action to the "Manage" page.

Users are normally approved from the "Approval Queue", but if you click into a user's profile to check them out in more detail it kind of dead ends you right now. I've occasionally hit this myself, and think this workflow is generally reasonable enough to support upstream.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 7 2019, 3:08 PM
epriestley requested review of this revision.Feb 7 2019, 3:10 PM
amckinley accepted this revision.Feb 7 2019, 8:51 PM
amckinley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
180–182

Maybe also (or alternatively) check for $is_admin and visually call out the "Not Approved" text in the header of this page? Or in the "Roles" property farther down the page.

This revision is now accepted and ready to land.Feb 7 2019, 8:51 PM

I also thought about putting a standalone "approve / reject" panel on the main profile page (not the "Manage" page), but I sort of want to modularize that at some point (so we can get a "member of instances: x, y" panel on admin.phacility.com) and don't want to make that any harder than it already is until that happens.

epriestley updated this revision to Diff 48053.Feb 7 2019, 10:48 PM
  • Pop those tags (visually, by giving them more color).
This revision was automatically updated to reflect the committed changes.