Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 4:26 PM

	Unknown Object (File)
	Thu, Dec 12, 4:46 AM

	Unknown Object (File)
	Thu, Dec 12, 2:59 AM

	Unknown Object (File)
	Fri, Dec 6, 4:01 PM

	Unknown Object (File)
	Sun, Dec 1, 5:39 PM

	Unknown Object (File)
	Fri, Nov 29, 9:30 AM

	Unknown Object (File)
	Tue, Nov 26, 3:59 PM

	Unknown Object (File)
	Tue, Nov 26, 7:10 AM

View All Files

Subscribers

None

Tokens

"100" token, awarded by amckinley."Dat Boi" token, awarded by cspeckmim.

Details

Reviewers

amckinley

Maniphest Tasks

T8907: Auto-focus first login field on login page

Commits

rP949afb02fd19: On login forms, autofocus the "username" field

Summary

Depends on D20120. Fixes T8907. I thought this needed some Javascript nonsense but Safari, Firefox and Chrome all support an autofocus attribute.

Test Plan

Loaded login page with password auth enabled in Safari, Firefox, and Chrome; saw username field automatically gain focus.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 7 2019, 4:55 AM

Harbormaster completed remote builds in B21877: Diff 48037.Feb 7 2019, 4:56 AM

epriestley requested review of this revision.Feb 7 2019, 4:56 AM

cspeckmim awarded a token.Feb 7 2019, 2:59 PM

epriestley added a child revision: D20123: Allow users to be approved from the profile "Manage" page, alongside other similar actions.Feb 7 2019, 3:08 PM

amckinley mentioned this in D20128: Autofocus form control for adding TOTP codes.Feb 7 2019, 7:37 PM

amckinley accepted this revision.Feb 7 2019, 7:39 PM

amckinley awarded a token.

This revision is now accepted and ready to land.Feb 7 2019, 7:40 PM

amckinley mentioned this in rPf2236eb061a6: Autofocus form control for adding TOTP codes.Feb 7 2019, 7:56 PM

Closed by commit rP949afb02fd19: On login forms, autofocus the "username" field (authored by epriestley). · Explain WhyFeb 7 2019, 11:03 PM

This revision was automatically updated to reflect the committed changes.

On login forms, autofocus the "username" field
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 48060

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

src/applications/auth/provider/PhabricatorPasswordAuthProvider.php

src/view/form/control/AphrontFormTextControl.php

On login forms, autofocus the "username" fieldClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48060

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

src/applications/auth/provider/PhabricatorPasswordAuthProvider.php

src/view/form/control/AphrontFormTextControl.php

On login forms, autofocus the "username" field
ClosedPublic
Actions

Revision Contents
Changeset List