Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
F18809104: D20117.diff
Sun, Oct 19, 11:12 AM
F18807688: D20117.id48032.diff
Sun, Oct 19, 2:59 AM
F18744811: D20117.id.diff
Fri, Oct 3, 4:15 AM
F18742774: D20117.diff
Thu, Oct 2, 9:19 PM
F18709819: D20117.id.diff
Mon, Sep 29, 1:00 AM
F18646945: D20117.id48032.diff
Sep 19 2025, 11:45 AM
F18644003: D20117.diff
Sep 19 2025, 4:02 AM
F18627749: D20117.diff
Sep 16 2025, 4:42 AM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable