Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
F17461665: D20117.diff
Tue, Jul 1, 9:10 PM
F17456251: D20117.id48130.diff
Tue, Jul 1, 7:10 PM
Unknown Object (File)
Mon, Jun 2, 10:14 AM
Unknown Object (File)
May 28 2025, 7:47 AM
Unknown Object (File)
May 27 2025, 8:53 PM
Unknown Object (File)
May 9 2025, 5:39 PM
Unknown Object (File)
May 5 2025, 9:11 PM
Unknown Object (File)
Apr 27 2025, 10:59 PM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable