Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
F15573519: D20117.id48130.diff
Mon, May 5, 9:11 PM
F15552858: D20117.id48130.diff
Sun, Apr 27, 10:59 PM
F15545641: D20117.id48032.diff
Sat, Apr 26, 11:49 AM
F15540197: D20117.id.diff
Fri, Apr 25, 6:45 AM
F15538574: D20117.diff
Thu, Apr 24, 8:05 PM
F15470536: D20117.id.diff
Apr 4 2025, 11:18 PM
F15454313: D20117.diff
Mar 29 2025, 5:52 PM
F15440017: D20117.id48032.diff
Mar 26 2025, 10:45 AM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable