Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 8:27 AM
Unknown Object (File)
Tue, Jan 28, 4:48 AM
Unknown Object (File)
Sun, Jan 26, 7:45 PM
Unknown Object (File)
Sun, Jan 26, 7:45 PM
Unknown Object (File)
Sat, Jan 25, 3:34 AM
Unknown Object (File)
Sat, Jan 25, 3:33 AM
Unknown Object (File)
Sat, Jan 25, 3:33 AM
Unknown Object (File)
Thu, Jan 23, 4:54 AM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable