Page MenuHomePhabricator

Don't show "registration might be too open" warnings unless an auth provider actually allows registration
ClosedPublic

Authored by epriestley on Feb 7 2019, 2:14 AM.

Details

Summary

Depends on D20118. Fixes T5351. We possibly raise some warnings about registration (approval queue, email domains), but they aren't relevant if no one can register.

Hide these warnings if no providers actually support registration.

Test Plan

Viewed the Auth provider list with registration providers and with no registration providers, saw more tailored guidance.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 7 2019, 2:14 AM
epriestley requested review of this revision.Feb 7 2019, 2:16 AM
amckinley accepted this revision.Feb 7 2019, 8:35 PM
This revision is now accepted and ready to land.Feb 7 2019, 8:35 PM
This revision was automatically updated to reflect the committed changes.