Page MenuHomePhabricator

Always require MFA to edit contact numbers
ClosedPublic

Authored by epriestley on Jan 23 2019, 8:00 PM.
Tags
None
Referenced Files
F14090649: D20024.diff
Sun, Nov 24, 7:24 PM
Unknown Object (File)
Oct 22 2024, 11:09 PM
Unknown Object (File)
Oct 18 2024, 12:32 PM
Unknown Object (File)
Oct 16 2024, 1:16 PM
Unknown Object (File)
Oct 9 2024, 11:26 AM
Unknown Object (File)
Sep 12 2024, 9:08 AM
Unknown Object (File)
Sep 7 2024, 3:36 AM
Unknown Object (File)
Sep 6 2024, 5:10 AM
Subscribers
None

Details

Summary

Depends on D20023. Ref T13222. Although I think this isn't strictly necessary from a pure security perspective (since you can't modify the primary number while you have MFA SMS), it seems like a generally good idea.

This adds a slightly new MFA mode, where we want MFA if it's available but don't strictly require it.

Test Plan

Disabled, enabled, primaried, unprimaried, and edited contact numbers. With MFA enabled, got prompted for MFA. With no MFA, no prompts.

Diff Detail

Repository
rP Phabricator
Branch
mfa19
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21650
Build 29527: Run Core Tests
Build 29526: arc lint + arc unit

Event Timeline

  • Minor wordsmithing since "MFAEngine" is about object state, not specifically about a set of edits.
This revision is now accepted and ready to land.Jan 23 2019, 10:09 PM
This revision was automatically updated to reflect the committed changes.