HomePhabricator

Prevent users from editing, disabling, or swapping their primary contact number…

Description

Prevent users from editing, disabling, or swapping their primary contact number while they have SMS MFA

Summary:
Depends on D20022. Ref T13222. Since you can easily lock yourself out of your account by swapping to a bad number, prevent contact number edits while "contact number" MFA (today, always SMS) is enabled.

(Another approach would be to bind factors to specific contact numbers, and then prevent that number from being edited or disabled while SMS MFA was attached to it. However, I think that's a bit more complicated and a little more unwieldy, and ends up in about the same place as this. I'd consider it more strongly in the future if we had like 20 users say "I have 9 phones" but I doubt this is a real use case.)

Test Plan:

  • With SMS MFA, tried to edit my primary contact number, disable it, and promote another number to become primary. Got a sensible error message in all cases.
  • After removing SMS MFA, did all that stuff with no issues.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13222

Differential Revision: https://secure.phabricator.com/D20023

Details

Provenance
epriestleyAuthored on Jan 23 2019, 7:08 PM
epriestleyPushed on Jan 23 2019, 10:18 PM
Reviewer
amckinley
Differential Revision
D20023: Prevent users from editing, disabling, or swapping their primary contact number while they have SMS MFA
Parents
rPada8a56bb7db: Implement SMS MFA
Branches
Unknown
Tags
Unknown
Tasks
T13222: 2018 Week 48-51 Bonus Content
Build Status
Buildable 21673
Build 29555: Run Core Tests