Page MenuHomePhabricator

Remove support for the "TYPE_AUTH_WILLLOGIN" event
ClosedPublic

Authored by epriestley on Dec 18 2018, 7:38 PM.
Tags
None
Referenced Files
F13196816: D19904.diff
Sun, May 12, 11:35 PM
F13176618: D19904.id47592.diff
Wed, May 8, 3:39 PM
Unknown Object (File)
Fri, May 3, 7:21 AM
Unknown Object (File)
Mon, Apr 29, 6:35 PM
Unknown Object (File)
Sun, Apr 28, 2:34 PM
Unknown Object (File)
Fri, Apr 26, 7:23 PM
Unknown Object (File)
Fri, Apr 26, 3:18 PM
Unknown Object (File)
Thu, Apr 25, 1:30 AM
Subscribers
None

Details

Summary

Depends on D19903. Ref T13222. This was a Facebook-specific thing from D6202 that I believe no other install ever used, and I'm generally trying to move away from the old "event" system (the more modern modular/engine patterns generally replace it).

Just drop support for this. Since the constant is being removed, anything that's actually using it should break in an obvious way, and I'll note this in the changelog.

There's no explicit replacement but I don't think this hook is useful for anything except "being Facebook in 2013".

Test Plan
  • Grepped for TYPE_AUTH_WILLLOGIN.
  • Logged in.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable