Page MenuHomePhabricator

Improve UI for "wait" and "answered" MFA challenges
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 3 2024, 8:26 PM
Unknown Object (File)
Jan 31 2024, 10:52 PM
Unknown Object (File)
Dec 23 2023, 7:16 AM
Unknown Object (File)
Dec 22 2023, 1:02 AM
Unknown Object (File)
Dec 20 2023, 8:54 PM
Unknown Object (File)
Dec 19 2023, 7:26 PM
Unknown Object (File)
Dec 11 2023, 3:46 PM
Unknown Object (File)
Dec 3 2023, 12:01 PM
Subscribers
None

Details

Summary

Depends on D19906. Ref T13222. This isn't going to win any design awards, but make the "wait" and "answered" elements a little more clear.

Ideally, the icon parts could be animated Google Authenticator-style timers (but I think we'd need to draw them in a <canvas /> unless there's some clever trick that I don't know) or maybe we could just have the background be like a "water level" that empties out. Not sure I'm going to actually write the JS for either of those, but the UI at least looks a little more intentional.

Test Plan

Screen Shot 2018-12-18 at 2.13.03 PM.png (849×1 px, 139 KB)

Screen Shot 2018-12-18 at 2.12.51 PM.png (849×1 px, 116 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Ideally, the icon parts could be animated Google Authenticator-style timers...

Not to create more work for you since this looks fine, but how about something like this? https://codepen.io/carsy/pen/VvqJwm

This revision is now accepted and ready to land.Dec 18 2018, 11:24 PM

Ah, neat. I've been wary of SVG since rendering user-controlled SVG (T6445) is such a horrible minefield, but I expect charting to be SVG-based so we're going to have to cross that bridge eventually...

This revision was automatically updated to reflect the committed changes.