Page MenuHomePhabricator

Remove support for the "TYPE_AUTH_WILLLOGIN" event
ClosedPublic

Authored by epriestley on Dec 18 2018, 7:38 PM.

Details

Summary

Depends on D19903. Ref T13222. This was a Facebook-specific thing from D6202 that I believe no other install ever used, and I'm generally trying to move away from the old "event" system (the more modern modular/engine patterns generally replace it).

Just drop support for this. Since the constant is being removed, anything that's actually using it should break in an obvious way, and I'll note this in the changelog.

There's no explicit replacement but I don't think this hook is useful for anything except "being Facebook in 2013".

Test Plan
  • Grepped for TYPE_AUTH_WILLLOGIN.
  • Logged in.

Diff Detail

Repository
rP Phabricator
Branch
mfa22
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 21369
Build 29091: Run Core Tests
Build 29090: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 18 2018, 7:38 PM
epriestley requested review of this revision.Dec 18 2018, 7:40 PM
amckinley accepted this revision.Dec 18 2018, 11:12 PM
This revision is now accepted and ready to land.Dec 18 2018, 11:12 PM
This revision was automatically updated to reflect the committed changes.