Page MenuHomePhabricator

Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:34 PM.

Details

Summary

Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of willApplyTransactions().

It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content.

This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.)

Test Plan
  • Created and edited a paste.
  • Grepped for willApplyTransactions().

Note that EditEngine (vs ApplicationTransacitonEditor) still has a willApplyTransactions(), which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 18 2018, 10:34 PM
epriestley requested review of this revision.Dec 18 2018, 10:36 PM
amckinley accepted this revision.Dec 18 2018, 11:26 PM
This revision is now accepted and ready to land.Dec 18 2018, 11:26 PM
This revision was automatically updated to reflect the committed changes.