Page MenuHomePhabricator

Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:34 PM.
Tags
None
Referenced Files
F18165780: D19909.id47596.diff
Fri, Aug 15, 9:00 AM
F18088723: D19909.id47524.diff
Wed, Aug 6, 9:05 AM
F17848521: D19909.id.diff
Jul 27 2025, 7:30 AM
F17833607: D19909.diff
Jul 26 2025, 1:43 PM
F17748995: D19909.diff
Jul 22 2025, 12:48 AM
F17676730: D19909.id47596.diff
Jul 13 2025, 10:12 AM
Unknown Object (File)
Jul 1 2025, 7:14 PM
Unknown Object (File)
Jun 29 2025, 6:02 PM
Subscribers
None

Details

Summary

Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of willApplyTransactions().

It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content.

This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.)

Test Plan
  • Created and edited a paste.
  • Grepped for willApplyTransactions().

Note that EditEngine (vs ApplicationTransacitonEditor) still has a willApplyTransactions(), which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable