Page MenuHomePhabricator

Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:34 PM.
Tags
None
Referenced Files
F15497080: D19909.id47596.diff
Sun, Apr 13, 9:50 AM
F15496840: D19909.id47524.diff
Sun, Apr 13, 8:24 AM
F15491706: D19909.id.diff
Sat, Apr 12, 6:41 AM
F15489879: D19909.diff
Fri, Apr 11, 1:04 PM
F15456438: D19909.id47524.diff
Sun, Mar 30, 9:42 AM
F15393884: D19909.diff
Sat, Mar 15, 11:12 PM
F15385642: D19909.diff
Mar 14 2025, 11:02 PM
F15360798: D19909.diff
Mar 11 2025, 10:17 AM
Subscribers
None

Details

Summary

Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of willApplyTransactions().

It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content.

This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.)

Test Plan
  • Created and edited a paste.
  • Grepped for willApplyTransactions().

Note that EditEngine (vs ApplicationTransacitonEditor) still has a willApplyTransactions(), which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable