Page MenuHomePhabricator

Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:34 PM.
Tags
None
Referenced Files
F22749994: D19909.id47596.diff
Sun, Oct 4, 8:44 PM
F22749992: D19909.id47596.diff
Sun, Oct 4, 8:44 PM
F22642952: D19909.id47524.diff
Wed, Sep 30, 3:01 PM
F22642949: D19909.id47524.diff
Wed, Sep 30, 3:01 PM
F22642945: D19909.id47524.diff
Wed, Sep 30, 3:01 PM
F22568206: D19909.id.diff
Sat, Sep 26, 1:57 AM
F22549476: D19909.diff
Wed, Sep 23, 3:30 AM
Unknown Object (File)
Sep 16 2026, 3:33 AM
Subscribers
None

Details

Summary

Depends on D19908. Ref T13222. In D19897, I reordered some transaction code and affected the call order of willApplyTransactions().

It turns out that we use this call for only one thing, and that thing is pretty silly: naming the raw paste data file when editing paste content.

This is only user-visible in the URL when you click "View Raw Paste" and seems exceptionally low-value, so remove the hook and pick a consistent name for the paste datafiles. (We could retain the name behavior in other ways, but it hardly seems worthwhile.)

Test Plan
  • Created and edited a paste.
  • Grepped for willApplyTransactions().

Note that EditEngine (vs ApplicationTransacitonEditor) still has a willApplyTransactions(), which has one callsite in Phabricator (in Calendar) and a couple in Instances. That's untouched and still works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable