Page MenuHomePhabricator

Remove support for the "TYPE_AUTH_WILLLOGIN" event
ClosedPublic

Authored by epriestley on Dec 18 2018, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:43 PM
Unknown Object (File)
Thu, Mar 21, 11:56 AM
Unknown Object (File)
Thu, Mar 21, 11:56 AM
Unknown Object (File)
Thu, Mar 21, 11:56 AM
Unknown Object (File)
Feb 24 2024, 5:05 PM
Unknown Object (File)
Feb 10 2024, 2:30 PM
Unknown Object (File)
Feb 9 2024, 1:07 AM
Unknown Object (File)
Feb 3 2024, 8:25 PM
Subscribers
None

Details

Summary

Depends on D19903. Ref T13222. This was a Facebook-specific thing from D6202 that I believe no other install ever used, and I'm generally trying to move away from the old "event" system (the more modern modular/engine patterns generally replace it).

Just drop support for this. Since the constant is being removed, anything that's actually using it should break in an obvious way, and I'll note this in the changelog.

There's no explicit replacement but I don't think this hook is useful for anything except "being Facebook in 2013".

Test Plan
  • Grepped for TYPE_AUTH_WILLLOGIN.
  • Logged in.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable