Page MenuHomePhabricator

Fix a double-prompt for MFA when recovering a password account
ClosedPublic

Authored by epriestley on Dec 18 2018, 8:04 PM.
Tags
None
Referenced Files
F15499957: D19906.id47594.diff
Sun, Apr 13, 3:39 PM
F15498592: D19906.id47517.diff
Sun, Apr 13, 1:27 PM
F15492378: D19906.id.diff
Sat, Apr 12, 1:52 PM
F15489317: D19906.diff
Fri, Apr 11, 7:53 AM
F15453598: D19906.id.diff
Sat, Mar 29, 12:54 PM
F15432793: D19906.id47517.diff
Mon, Mar 24, 7:39 PM
F15398103: D19906.id47517.diff
Sun, Mar 16, 11:17 PM
F15383276: D19906.diff
Mar 14 2025, 4:03 PM
Subscribers
None

Details

Summary

Depends on D19905. Ref T13222. In D19843, I refactored this stuff but $jump_into_hisec was dropped.

This is a hint to keep the upgraded session in hisec mode, which we need to do a password reset when using a recovery link. Without it, we double prompt you for MFA: first to upgrade to a full session, then to change your password.

Pass this into the engine properly to avoid the double-prompt.

Test Plan
  • Used bin/auth recover to get a partial session with MFA enabled and a password provider.
  • Before: double MFA prompt.
  • After: session stays upgraded when it becomes full, no second prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable