Page MenuHomePhabricator

Fix a double-prompt for MFA when recovering a password account
ClosedPublic

Authored by epriestley on Dec 18 2018, 8:04 PM.
Tags
None
Referenced Files
F18744427: D19906.diff
Fri, Oct 3, 2:57 AM
F18741160: D19906.id.diff
Thu, Oct 2, 9:01 AM
F18736808: D19906.diff
Wed, Oct 1, 7:51 AM
F18673480: D19906.diff
Thu, Sep 25, 10:47 AM
F18673060: D19906.diff
Thu, Sep 25, 9:12 AM
F18654486: D19906.id47517.diff
Sep 22 2025, 11:40 AM
F18597905: D19906.id47594.diff
Sep 13 2025, 3:55 AM
F18596721: D19906.diff
Sep 13 2025, 1:20 AM
Subscribers
None

Details

Summary

Depends on D19905. Ref T13222. In D19843, I refactored this stuff but $jump_into_hisec was dropped.

This is a hint to keep the upgraded session in hisec mode, which we need to do a password reset when using a recovery link. Without it, we double prompt you for MFA: first to upgrade to a full session, then to change your password.

Pass this into the engine properly to avoid the double-prompt.

Test Plan
  • Used bin/auth recover to get a partial session with MFA enabled and a password provider.
  • Before: double MFA prompt.
  • After: session stays upgraded when it becomes full, no second prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable