Page MenuHomePhabricator

Tighten some MFA/TOTP parameters to improve resistance to brute force attacks
ClosedPublic

Authored by epriestley on Dec 18 2018, 2:01 PM.
Tags
None
Referenced Files
F12189517: D19898.id.diff
Tue, Sep 19, 4:13 PM
F12185486: D19898.diff
Sat, Sep 16, 9:16 AM
F12166359: D19898.diff
Thu, Sep 7, 1:25 AM
F12150436: D19898.id47508.diff
Sat, Sep 2, 7:01 PM
F12148828: D19898.id47586.diff
Sat, Sep 2, 3:09 AM
Unknown Object (File)
Jul 17 2023, 4:51 PM
Unknown Object (File)
Jul 12 2023, 1:20 PM
Unknown Object (File)
Jul 4 2023, 10:26 PM
Subscribers
None

Details

Summary

Depends on D19897. Ref T13222. See some discussion in D19890.

  • Only rate limit users if they're actually answering a challenge, not if they're just clicking "Wait Patiently".
  • Reduce the number of allowed attempts per hour from 100 back to 10.
  • Reduce the TOTP window from +/- 2 timesteps (allowing ~60 seconds of skew) to +/- 1 timestep (allowing ~30 seconds of skew).
  • Change the window where a TOTP response remains valid to a flat 60 seconds instead of a calculation based on windows and timesteps.
Test Plan
  • Hit an MFA prompt.
  • Without typing in any codes, mashed "submit" as much as I wanted (>>10 times / hour).
  • Answered prompt correctly.
  • Mashed "Wait Patiently" as much as I wanted (>>10 times / hour).
  • Guessed random numbers, was rate limited after 10 attempts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable