Page MenuHomePhabricator

Tighten some MFA/TOTP parameters to improve resistance to brute force attacks
ClosedPublic

Authored by epriestley on Dec 18 2018, 2:01 PM.
Tags
None
Referenced Files
F19463174: D19898.id.diff
Fri, Jan 2, 10:33 PM
F19462376: D19898.diff
Fri, Jan 2, 9:36 PM
F19100060: D19898.id.diff
Dec 4 2025, 10:08 PM
F19093764: D19898.diff
Dec 3 2025, 10:28 PM
F19081246: D19898.diff
Dec 2 2025, 5:00 AM
F19081215: D19898.diff
Dec 2 2025, 4:34 AM
F19081202: D19898.diff
Dec 2 2025, 4:25 AM
F19081139: D19898.diff
Dec 2 2025, 4:14 AM
Subscribers
None

Details

Summary

Depends on D19897. Ref T13222. See some discussion in D19890.

  • Only rate limit users if they're actually answering a challenge, not if they're just clicking "Wait Patiently".
  • Reduce the number of allowed attempts per hour from 100 back to 10.
  • Reduce the TOTP window from +/- 2 timesteps (allowing ~60 seconds of skew) to +/- 1 timestep (allowing ~30 seconds of skew).
  • Change the window where a TOTP response remains valid to a flat 60 seconds instead of a calculation based on windows and timesteps.
Test Plan
  • Hit an MFA prompt.
  • Without typing in any codes, mashed "submit" as much as I wanted (>>10 times / hour).
  • Answered prompt correctly.
  • Mashed "Wait Patiently" as much as I wanted (>>10 times / hour).
  • Guessed random numbers, was rate limited after 10 attempts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable