Page MenuHomePhabricator

In Legalpad, prompt for MFA at the end of the workflow instead of the beginning
ClosedPublic

Authored by epriestley on Dec 17 2018, 7:23 PM.
Tags
None
Referenced Files
F15552792: D19896.id47504.diff
Sun, Apr 27, 10:39 PM
F15551793: D19896.diff
Sun, Apr 27, 6:36 PM
F15535827: D19896.id47504.diff
Thu, Apr 24, 7:00 AM
F15531942: D19896.diff
Wed, Apr 23, 1:56 PM
F15526319: D19896.diff
Mon, Apr 21, 8:35 PM
F15520280: D19896.id47505.diff
Sun, Apr 20, 5:16 AM
F15512540: D19896.id47505.diff
Thu, Apr 17, 11:26 AM
F15512535: D19896.id47504.diff
Thu, Apr 17, 11:24 AM
Subscribers
None

Details

Summary

Depends on D19895. Ref T13222. This is a simple behavioral improvement for the current MFA implementation in Legalpad: don't MFA the user and then realize that they forgot to actually check the box.

Test Plan
  • Submitted form without the box checked, got an error saying "check the box" instead of MFA.
  • Submitted the form with the box checked, got an MFA prompt.
  • Passed the MFA gate, got a signed form.
  • Tried to sign another form, hit MFA timed lockout.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable