Page MenuHomePhabricator

In Legalpad, prompt for MFA at the end of the workflow instead of the beginning
ClosedPublic

Authored by epriestley on Dec 17 2018, 7:23 PM.

Details

Summary

Depends on D19895. Ref T13222. This is a simple behavioral improvement for the current MFA implementation in Legalpad: don't MFA the user and then realize that they forgot to actually check the box.

Test Plan
  • Submitted form without the box checked, got an error saying "check the box" instead of MFA.
  • Submitted the form with the box checked, got an MFA prompt.
  • Passed the MFA gate, got a signed form.
  • Tried to sign another form, hit MFA timed lockout.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 47505.Dec 17 2018, 7:23 PM
epriestley created this revision.
  • Actual change which does what I claim.
Harbormaster completed remote builds in B21359: Diff 47505.
epriestley requested review of this revision.Dec 17 2018, 7:26 PM
amckinley accepted this revision.Dec 18 2018, 8:50 PM
This revision is now accepted and ready to land.Dec 18 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.