Page MenuHomePhabricator

Allow "MFA Required" objects to be edited without MFA if the edit is only creating inverse edges
ClosedPublic

Authored by epriestley on Dec 18 2018, 4:12 PM.

Details

Summary

Depends on D19900. Ref T13222. See PHI873. When an object requires MFA, we currently require MFA for every transaction.

This includes some ambiguous cases like "unsubscribe", but also includes "mention", which seems like clearly bad behavior.

Allow an "MFA" object to be the target of mentions, "edit child tasks", etc.

Test Plan
  • Mentioned an MFA object elsewhere (no MFA prompt).
  • Made an MFA object a subtask of a non-MFA object (no MFA prompt).
  • Tried to edit an MFA object normally (still got an MFA prompt).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 18 2018, 4:12 PM
epriestley requested review of this revision.Dec 18 2018, 4:14 PM
amckinley accepted this revision.Dec 18 2018, 10:40 PM
This revision is now accepted and ready to land.Dec 18 2018, 10:40 PM
This revision was automatically updated to reflect the committed changes.