Page MenuHomePhabricator

Remove support for the "TYPE_AUTH_WILLLOGIN" event
ClosedPublic

Authored by epriestley on Dec 18 2018, 7:38 PM.
Tags
None
Referenced Files
F13088615: D19904.diff
Thu, Apr 25, 1:30 AM
Unknown Object (File)
Tue, Apr 16, 4:45 PM
Unknown Object (File)
Thu, Apr 11, 9:00 AM
Unknown Object (File)
Sun, Apr 7, 3:44 PM
Unknown Object (File)
Mar 23 2024, 5:43 PM
Unknown Object (File)
Mar 21 2024, 11:56 AM
Unknown Object (File)
Mar 21 2024, 11:56 AM
Unknown Object (File)
Mar 21 2024, 11:56 AM
Subscribers
None

Details

Summary

Depends on D19903. Ref T13222. This was a Facebook-specific thing from D6202 that I believe no other install ever used, and I'm generally trying to move away from the old "event" system (the more modern modular/engine patterns generally replace it).

Just drop support for this. Since the constant is being removed, anything that's actually using it should break in an obvious way, and I'll note this in the changelog.

There's no explicit replacement but I don't think this hook is useful for anything except "being Facebook in 2013".

Test Plan
  • Grepped for TYPE_AUTH_WILLLOGIN.
  • Logged in.

Diff Detail

Repository
rP Phabricator
Branch
mfa22
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21369
Build 29091: Run Core Tests
Build 29090: arc lint + arc unit