Page MenuHomePhabricator

Modularize Almanac Namespace transactions
ClosedPublic

Authored by epriestley on Apr 10 2018, 11:51 AM.
Tags
None
Referenced Files
F14092149: D19320.diff
Mon, Nov 25, 4:21 AM
Unknown Object (File)
Fri, Nov 22, 4:56 PM
Unknown Object (File)
Mon, Nov 18, 6:11 PM
Unknown Object (File)
Fri, Nov 15, 1:42 AM
Unknown Object (File)
Sun, Nov 10, 7:52 PM
Unknown Object (File)
Sat, Nov 9, 3:07 PM
Unknown Object (File)
Wed, Nov 6, 11:47 PM
Unknown Object (File)
Sat, Oct 26, 8:12 AM
Subscribers
None

Details

Summary

Depends on D19318. Ref T13120. Ref T12414. Move transactions for Almanac Namespaces ("name" is the only meaningful one) to ModularTransactions.

Test Plan
  • Created a new namespace.
  • Edited a namespace.
  • Tried to choose no name, an invalid name, a duplicate name, and a name in a namespace I can't edit; got appropriate errors.
  • Grepped for AlmanacNamespaceTransaction::TYPE_NAME.

Diff Detail

Repository
rP Phabricator
Branch
almanac5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20050
Build 27192: Run Core Tests
Build 27191: arc lint + arc unit