Page MenuHomePhabricator

Modularize Almanac Namespace transactions
ClosedPublic

Authored by epriestley on Apr 10 2018, 11:51 AM.
Tags
None
Referenced Files
F13365778: D19320.diff
Wed, Jun 26, 4:43 PM
F13359757: D19320.diff
Tue, Jun 25, 10:20 AM
F13356345: D19320.id46261.diff
Mon, Jun 24, 4:32 PM
F13354777: D19320.diff
Mon, Jun 24, 7:48 AM
F13345554: D19320.diff
Fri, Jun 21, 10:44 AM
F13300136: D19320.diff
Fri, Jun 7, 8:51 AM
F13283559: D19320.diff
Sun, Jun 2, 3:52 PM
F13269927: D19320.diff
May 29 2024, 8:13 AM
Subscribers
None

Details

Summary

Depends on D19318. Ref T13120. Ref T12414. Move transactions for Almanac Namespaces ("name" is the only meaningful one) to ModularTransactions.

Test Plan
  • Created a new namespace.
  • Edited a namespace.
  • Tried to choose no name, an invalid name, a duplicate name, and a name in a namespace I can't edit; got appropriate errors.
  • Grepped for AlmanacNamespaceTransaction::TYPE_NAME.

Diff Detail

Repository
rP Phabricator
Branch
almanac5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20050
Build 27192: Run Core Tests
Build 27191: arc lint + arc unit