Page MenuHomePhabricator

Change "lint save" to not use Arcanist Projects
ClosedPublic

Authored by joshuaspence on May 18 2015, 12:32 PM.
Tags
None
Referenced Files
F13248254: D12893.id.diff
Fri, May 24, 2:11 AM
F13232737: D12893.diff
Tue, May 21, 1:28 AM
F13220212: D12893.diff
Sat, May 18, 11:57 PM
F13217612: D12893.id31026.diff
Sat, May 18, 6:27 AM
F13217611: D12893.id31017.diff
Sat, May 18, 6:27 AM
F13217562: D12893.id.diff
Sat, May 18, 6:21 AM
F13217427: D12893.diff
Sat, May 18, 5:16 AM
F13213485: D12893.diff
Fri, May 17, 7:49 AM
Subscribers

Details

Summary

Ref T7604. Change DiffusionLintSaveRunner to use repositories instead of Arcanist Projects.

Test Plan

Ran the save_lint.php script and queried results using the diffusion.getlintmessages Conduit endpoint.

Diff Detail

Repository
rP Phabricator
Branch
arpj1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6058
Build 6078: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Change "lint save" to not use Arcanist Projects.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 1:28 PM

It looks like arcanist calls the conduit endpoint with arcanistProjectPHID... so perhaps we need to keep this parameter around for a while?

Oh -- it only does if you pass --only-new, which I think is very, very rarely used. I don't think we need to retain compatibility too carefully. Just shoot me a diff to swap the call?

src/applications/diffusion/DiffusionLintSaveRunner.php
67

Maybe this should be changed to be $this->actor and then the omnipotent user is set via setActor.

src/applications/diffusion/DiffusionLintSaveRunner.php
67

In the long run, the design of this is weird, anyway, in the context of modern CLI scripts. I think we should move it into bin at some point and make it (CLI) Workflow-based (e.g., bin/repository import-symbols), when it gets a getViewer() automatically (which just evaluates to the omnipotent user). Fixing it up in advance of that is fine, but maybe not worth bothering with.

This revision was automatically updated to reflect the committed changes.