Ref T7604. Change DiffusionLintSaveRunner to use repositories instead of Arcanist Projects.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7604: Remove "Arcanist Projects"
- Commits
- Restricted Diffusion Commit
rPf8b7f0314598: Change "lint save" to not use Arcanist Projects
Ran the save_lint.php script and queried results using the diffusion.getlintmessages Conduit endpoint.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- arpj1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6058 Build 6078: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
It looks like arcanist calls the conduit endpoint with arcanistProjectPHID... so perhaps we need to keep this parameter around for a while?
Comment Actions
Oh -- it only does if you pass --only-new, which I think is very, very rarely used. I don't think we need to retain compatibility too carefully. Just shoot me a diff to swap the call?
| src/applications/diffusion/DiffusionLintSaveRunner.php | ||
|---|---|---|
| 67 | Maybe this should be changed to be $this->actor and then the omnipotent user is set via setActor. | |
| src/applications/diffusion/DiffusionLintSaveRunner.php | ||
|---|---|---|
| 67 | In the long run, the design of this is weird, anyway, in the context of modern CLI scripts. I think we should move it into bin at some point and make it (CLI) Workflow-based (e.g., bin/repository import-symbols), when it gets a getViewer() automatically (which just evaluates to the omnipotent user). Fixing it up in advance of that is fine, but maybe not worth bothering with. | |