Page MenuHomePhabricator
Differential D13401

Make Differential load lint/unit data from Harbormaster
ClosedPublic
Actions

Authored by epriestley on Jun 23 2015, 2:23 PM.
Tags
None
Referenced Files
F14779232: D13401.id32461.diff
Fri, Jan 24, 6:41 AM
F14779231: D13401.id32450.diff
Fri, Jan 24, 6:41 AM
F14779230: D13401.id.diff
Fri, Jan 24, 6:41 AM
F14779229: D13401.diff
Fri, Jan 24, 6:41 AM
Unknown Object (File)
Wed, Jan 22, 7:47 PM
Unknown Object (File)
Tue, Jan 21, 9:47 AM
Unknown Object (File)
Dec 13 2024, 5:32 PM
Unknown Object (File)
Dec 2 2024, 10:57 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8095: Let Harbormaster own Lint and Unit results
Commits
Restricted Diffusion Commit
rPde30e15b7ec8: Make Differential load lint/unit data from Harbormaster
Summary

Fixes T8095. Still needs UI/UX work (see T8096) but this has all the core features now.

Test Plan

Saw Harbormaster lint/unit data as though it was Differential lint-unit data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32450.Jun 23 2015, 2:23 PM
epriestley retitled this revision from to Make Differential load lint/unit data from Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2015, 2:23 PM
btrahan accepted this revision.Jun 23 2015, 5:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2015, 5:07 PM
Closed by commit rPde30e15b7ec8: Make Differential load lint/unit data from Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
differential/
controller/
19 lines
customfield/
14 lines
14 lines
storage/
10 lines
harbormaster/
query/
42 lines

Diff 32461

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

Loading...
Phabricator · Built by Phacility