HomePhabricator

Render lint results as Harbormaster lint messages

Description

Render lint results as Harbormaster lint messages

Summary:
Ref T8095. Render lint results in a future-ready way.

This makes the renderer accept HarbormasterBuildLintMessage objects. If we have legacy data instead, it converts it into HarbormasterBuildLintMessage objects.

Design is a bit rough but will be cleaned up later after T7739.

This moves away from "postponed linters", which are obsolete after Harbormaster (and were only ever used by Facebook).

Test Plan:

Screen Shot 2015-06-21 at 10.09.34 AM.png (291×1 px, 61 KB)

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8095

Differential Revision: https://secure.phabricator.com/D13377

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jun 23 2015, 5:23 PM
Reviewer
btrahan
Differential Revision
D13377: Render lint results as Harbormaster lint messages
Parents
rP54888e1aa821: Implemented Mentionable interface in Pholio
Branches
Unknown
Tags
Unknown
Tasks
T8095: Let Harbormaster own Lint and Unit results