Page MenuHomePhabricator
Differential D13378

Render unit results as Harbormaster unit messages
ClosedPublic
Actions

Authored by epriestley on Jun 21 2015, 5:39 PM.
Tags
None
Referenced Files
F18899157: D13378.diff
Fri, Nov 7, 7:32 PM
F18810527: D13378.id32456.diff
Oct 19 2025, 10:02 PM
F18777423: D13378.id32390.diff
Oct 11 2025, 2:51 AM
F18697603: D13378.id.diff
Sep 27 2025, 9:53 AM
F18696443: D13378.diff
Sep 27 2025, 7:50 AM
F18628878: D13378.diff
Sep 16 2025, 7:29 AM
F18544265: D13378.diff
Sep 8 2025, 12:31 AM
F18498467: D13378.diff
Sep 4 2025, 6:44 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8095: Let Harbormaster own Lint and Unit results
Commits
Restricted Diffusion Commit
rPb72deb332ca7: Render unit results as Harbormaster unit messages
Summary

Ref T8095. Same as D13377, but for unit results.

This is a bit rough and there's some duplication between this and unit results. I'll likely merge them later, but I think some of it is superficial since these iterations are still a little crude.

Test Plan

Screen Shot 2015-06-21 at 10.37.40 AM.png (176×1 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32390.Jun 21 2015, 5:39 PM
epriestley retitled this revision from to Render unit results as Harbormaster unit messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 21 2015, 5:39 PM
btrahan accepted this revision.Jun 22 2015, 5:02 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2015, 5:02 PM
Closed by commit rPb72deb332ca7: Render unit results as Harbormaster unit messages (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
customfield/
20 lines
250 lines
harbormaster/
storage/
build/
2 lines
view/
90 lines

Diff 32456

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterUnitPropertyView.php

Loading...
Phabricator · Built by Phacility