Page MenuHomePhabricator
Differential D11536

Submit the `arc:generated` property with `arc diff`
AbandonedPublic
Actions

Authored by joshuaspence on Jan 28 2015, 8:53 AM.
Tags
None
Referenced Files
F15429431: D11536.id27753.diff
Mon, Mar 24, 2:13 AM
F15427904: D11536.id27754.diff
Sun, Mar 23, 5:09 PM
F15423279: D11536.id27941.diff
Sat, Mar 22, 2:28 PM
F15419117: D11536.id27928.diff
Fri, Mar 21, 3:38 AM
F15417876: D11536.id27754.diff
Thu, Mar 20, 7:07 PM
F15413699: D11536.id.diff
Wed, Mar 19, 8:39 PM
F15409926: D11536.id31666.diff
Wed, Mar 19, 5:59 AM
F15406706: D11536.diff
Tue, Mar 18, 1:25 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T784: Allow Differential changesets to be marked with various attributes
Summary

Ref T784. When submitting a differential, also submit the arc:generated property so that generated paths are collapsed in the Differential UI. Depends on D11535.

Test Plan

Uploaded a diff and saw generated paths.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6457
Build 6479: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27753.Jan 28 2015, 8:53 AM
joshuaspence retitled this revision from to Submit the `arc:generated` property with `arc diff`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T784: Allow Differential changesets to be marked with various attributes.
joshuaspence added a parent revision: D11535: Allow differential changesets to be marked as generated via diff properties.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2015, 8:53 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 27754.Jan 28 2015, 9:00 AM
joshuaspence edited edge metadata.

Add help text

joshuaspence updated this object.Feb 1 2015, 9:24 PM
joshuaspence updated this revision to Diff 27928.Feb 1 2015, 9:27 PM

Improve help text

joshuaspence updated this revision to Diff 27941.Feb 2 2015, 7:33 AM
  • Remove unrelated changes
  • Set default value for generated-paths
joshuaspence added a child revision: D11537: Allow `ArcanistGeneratedLinter` to respect `generated-paths`.Feb 2 2015, 7:33 AM
joshuaspence updated this revision to Diff 31666.Jun 2 2015, 2:09 PM

Fix example

joshuaspence abandoned this revision.Jun 21 2015, 10:56 PM

See T8095#122313.

Revision Contents
Changeset List

PathSize
src/
configuration/
8 lines
workflow/
13 lines

Diff 31666

View Options

src/configuration/ArcanistSettings.php

Loading...
View Options

src/workflow/ArcanistDiffWorkflow.php

Loading...
Phabricator · Built by Phacility