Page MenuHomePhabricator

Fix audit commenting where there are only inlines

Authored by btrahan on Jul 30 2014, 5:43 PM.
Referenced Files
Unknown Object (File)
Tue, Mar 21, 8:04 PM
Unknown Object (File)
Feb 17 2023, 8:25 PM
Unknown Object (File)
Feb 10 2023, 10:50 PM
Unknown Object (File)
Feb 5 2023, 5:18 AM
Unknown Object (File)
Feb 5 2023, 5:16 AM
Unknown Object (File)
Feb 5 2023, 4:59 AM
Unknown Object (File)
Feb 5 2023, 4:28 AM
Unknown Object (File)
Feb 3 2023, 11:43 PM



been some changes here and this code was broked. turns out we re-assign $action like two lines later and never used the initial value, so we can simply delete the offending line. Fixes T5745.

Test Plan

submitted inline comment pre-patch and fatal. re-submitted post patch and great success!

Diff Detail

rP Phabricator
Lint Skipped
Tests Skipped

Event Timeline

btrahan retitled this revision from to Fix audit commenting where there are only inlines.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

We swapped to a different datasource for the "which things are native in PHP", it might be missing ZipArchive.

This revision is now accepted and ready to land.Jul 30 2014, 5:46 PM
btrahan updated this revision to Diff 24236.

Closed by commit rP98c2ad38e564 (authored by @btrahan).