Differential D10078

Fix audit commenting where there are only inlines
ClosedPublic
Actions

Authored by btrahan on Jul 30 2014, 5:43 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5745: Unable to post only inline comments to an audit

Commits

Restricted Diffusion Commit
rP98c2ad38e564: Fix audit commenting where there are only inlines

Summary

been some changes here and this code was broked. turns out we re-assign $action like two lines later and never used the initial value, so we can simply delete the offending line. Fixes T5745.

Test Plan

submitted inline comment pre-patch and fatal. re-submitted post patch and great success!

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24235.Jul 30 2014, 5:43 PM

btrahan added a task: T5745: Unable to post only inline comments to an audit.

btrahan retitled this revision from to Fix audit commenting where there are only inlines.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 30 2014, 5:43 PM

Harbormaster completed remote builds in B1937: Diff 24235.Jul 30 2014, 5:44 PM

We swapped to a different datasource for the "which things are native in PHP", it might be missing ZipArchive.

This revision is now accepted and ready to land.Jul 30 2014, 5:46 PM

Closed by commit rP98c2ad38e564 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditCommentEditor.php

2 lines

Diff 24236

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Fix audit commenting where there are only inlinesClosedPublicActions