Page MenuHomePhabricator
Create Task
Maniphest T5245

Migrate Maniphest Projects to use edge infrastructure
Closed, ResolvedPublic
Actions

Description

Migrate Maniphest Projects (i.e. the ManiphestTaskProject class) to use edge infrastructure.

Revisions and Commits

rP Phabricator
ClosedD9973 Remove a stray `setActor()` on EdgeEditor
ClosedD9340 Implement PhabricatorProjectInterface for marking that objects can be tagged with projects
D11032rPe76499bbbb62 Maniphest - kill TYPE_PROJECTS
D11013rP10f2cfec5b37 Maniphest - remove references to deprecated transaction type TYPE_PROJECTS from…
D11004rP83db5965ab6c Maniphest - introduce needProjectPHIDs
D10177rP20d8b1bdd36a Implement PhabricatorProjectInterface on ManiphestTask
D9920rP086fe952e65e Add translated strings for new edge types
D9852rPe8c490958c8a Stop writing new TYPE_PROJECTS transactions to Maniphest
D9851rPb8b59895eeec Stop reads and writes to projectPHIDs property on ManiphestTask
D9850rPaa7953978975 Move task/project storage to edges
D9849rP33120e377a63 Modernize Project/Object edges
D9848rPd4b2bfa2f4c1 Modernize commit/edge transaction when parsing commit messages
D9841rPb32313cc85d8 Use PhabricatorEdgeType strings when rendering transactions
D9840rP8cbfb49b4e93 Remove all edge events
D9839rP533e799c5f7e Modernize task/revision edges and write inverse transactions
D9838rPace1feb70220 Implement PhabricatorApplicationTransactionInterface on ManiphestTask
D9837rP7afb770cbe07 Make edge types modular
D9833rP7deec8208ff9 Make Maniphest project edits more transaction-oriented

Related Objects
Search...

Event Timeline

joshuaspence created this task.Jun 3 2014, 12:34 AM
joshuaspence claimed this task.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Maniphest.
joshuaspence added a subscriber: joshuaspence.
joshuaspence removed joshuaspence as the assignee of this task.Jun 3 2014, 11:46 PM

I don't think that I know enough about Phabricator to complete this task.

epriestley edited this Maniphest Task.Jun 4 2014, 12:20 AM
epriestley added a subscriber: epriestley.Jun 4 2014, 12:21 AM

D9340 slightly related.

This is probably pretty involved, I'll take a stab at it at some point. I don't think it gives us a ton of stuff, but would let us clean up a few things.

joshuaspence assigned this task to epriestley.Jun 8 2014, 3:18 AM
epriestley edited this Maniphest Task.Jun 24 2014, 4:39 PM
aklapper added a subscriber: aklapper.Jul 2 2014, 3:26 PM
epriestley edited this Maniphest Task.Jul 5 2014, 5:14 PM
epriestley edited this Maniphest Task.Jul 5 2014, 7:44 PM
epriestley renamed this task from Migrate Maniphest Projects to use edge infrastructure. to Migrate Maniphest Projects to use edge infrastructure.Jul 5 2014, 7:44 PM
epriestley edited this Maniphest Task.Jul 5 2014, 8:09 PM
epriestley edited this Maniphest Task.Jul 5 2014, 9:42 PM
epriestley edited this Maniphest Task.Jul 5 2014, 10:00 PM
epriestley edited this Maniphest Task.Jul 5 2014, 10:30 PM
epriestley edited this Maniphest Task.Jul 5 2014, 10:41 PM
epriestley edited this Maniphest Task.Jul 5 2014, 10:48 PM
epriestley triaged this task as Normal priority.Jul 6 2014, 2:30 PM
epriestley edited this Maniphest Task.Jul 6 2014, 2:31 PM
epriestley edited this Maniphest Task.Jul 6 2014, 2:43 PM
epriestley edited this Maniphest Task.Jul 6 2014, 3:09 PM
epriestley edited this Maniphest Task.Jul 6 2014, 3:28 PM
epriestley edited this Maniphest Task.Jul 6 2014, 4:07 PM
epriestley edited this Maniphest Task.Jul 10 2014, 7:33 PM
epriestley added a subscriber: mbishopim3.Jul 12 2014, 2:27 PM

◀ Merged tasks: T5190.

epriestley edited this Maniphest Task.Jul 13 2014, 4:21 PM
epriestley edited this Maniphest Task.Jul 13 2014, 5:21 PM
epriestley edited this Maniphest Task.Jul 17 2014, 10:40 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.Jul 17 2014, 10:42 PM
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
timor added a subscriber: timor.Jul 18 2014, 11:50 AM
epriestley added a comment.Jul 18 2014, 11:54 AM

This is mostly complete, but:

  • Maniphest should implement PhabricatorProjectInterface, but picks up two "Projects" fields in the UI if it does. Its projects field currently shows board columns, so we can't just delete that copy. After T4807, we can generalize this and implement PhabricatorProjectInterface.
  • It would be nice to migrate old TYPE_PROJECTS transactions to TYPE_EDGE transactions to remove leftover rendering code.
joshuaspence added a revision: D9973: Remove a stray `setActor()` on EdgeEditor.Jul 19 2014, 2:52 AM
epriestley added a revision: D10177: Implement PhabricatorProjectInterface on ManiphestTask.Aug 7 2014, 5:11 PM
epriestley added a commit: rP20d8b1bdd36a: Implement PhabricatorProjectInterface on ManiphestTask.Aug 7 2014, 10:44 PM
epriestley added a project: Support Impact.Oct 3 2014, 4:08 AM

Support Impact While this is mostly resolved, it created inconsistencies and blocked other tasks.

btrahan claimed this task.Dec 4 2014, 11:05 PM
In T5245#68198, @epriestley wrote:

This is mostly complete, but:

  • Maniphest should implement PhabricatorProjectInterface, but picks up two "Projects" fields in the UI if it does. Its projects field currently shows board columns, so we can't just delete that copy. After T4807, we can generalize this and implement PhabricatorProjectInterface.
  • It would be nice to migrate old TYPE_PROJECTS transactions to TYPE_EDGE transactions to remove leftover rendering code.

Stealing this from you to do these bits...? Feel free to take back if you have something on it as I won't be getting started on this for a few hours at least.

epriestley added a comment.Dec 5 2014, 1:09 AM

Stealing this from you to do these bits...?

Go for it. First one is definitely worth doing but the the second one may be more trouble than it's worth (we only get to remove a fairly small amount of dead code, I think, and it could be a long trek to get there).

btrahan added a revision: D11004: Maniphest - introduce needProjectPHIDs.Dec 17 2014, 11:04 PM
btrahan added a commit: rP83db5965ab6c: Maniphest - introduce needProjectPHIDs.Dec 18 2014, 9:53 PM
btrahan added a revision: D11013: Maniphest - remove references to deprecated transaction type TYPE_PROJECTS from code.Dec 18 2014, 10:12 PM
btrahan added a commit: rP10f2cfec5b37: Maniphest - remove references to deprecated transaction type TYPE_PROJECTS from….Dec 18 2014, 10:17 PM
btrahan added a revision: D11032: Maniphest - kill TYPE_PROJECTS.Dec 22 2014, 7:45 PM
btrahan closed this task as Resolved.Dec 22 2014, 7:54 PM
btrahan added a commit: rPe76499bbbb62: Maniphest - kill TYPE_PROJECTS.

Closed by commit rPe76499bbbb62.

ChristopherHJohnson added a subscriber: ChristopherHJohnson.Dec 25 2014, 2:44 PM

Please check https://secure.phabricator.com/maniphest/report/project/

This is the result of this change:
rP83db5965ab6c: Maniphest - introduce needProjectPHIDs

joshuaspence mentioned this in T9789: Make it easier to write custom transaction types.Nov 15 2015, 12:05 AM
Phabricator · Built by Phacility