Ref T5245. This is some of the associated cleanup there.

foreach ManiphestTaskQuery site, I made the change (or not) and tested as follows:

Call sites where added needProjectPHIDs

• PhabricatorHomeMainController - loaded the home page
• ManiphestBatchEditController - batch edited some tasks (added a project)
• ManiphestConduitAPIMethod - tested implicitly when tested ManiphestUpdateConduitAPIMethod
• ManiphestInfoConduitAPIMethod - used the method via conduit console with input id : 1
• ManiphestQueryConduitAPIMethod - used the method via conduit console with input ids : [1, 2]
• ManiphestUpdateConduitAPIMethod - used the method via conduit with input id : 1 and comment : “asdasds"
• ManiphestReportController - viewed “By User” and “By Project”
• ManiphestSubpriorityController - changed the priority of a task via a drag on manphest home
• ManiphestTaskMailReceiver - updated Task 1 via bin/mail receive-test with a comment that is the README
• ManiphestTaskSearchEngine - loaded Manifest home page
• ManiphestTaskEditController - edited a task
• ManiphestTransactionEditor - closed a blocking task
• ManiphestTransactionSaveController - commented on a task
• PhabricatorProjectProfileController - viewed project with id of 1 that has a few tasks in it
• PhabricatorSearchAttachController - merged tasks together
• DifferentialTransactionEditor - submit a diff that references a task; commit the diff (thus closing the diff) and the task gets updated
• PhabricatorRepositoryCommitMessageParserWorker - submit a diff that references a task; commit the diff (thus closing the diff) and the task gets updated

Calls sites where *did not* add needProjectPHIDs (they do not appear in this revision)

• PhabricatorManiphestApplication - loaded the home page
• ManiphestGetTaskTransactionsConduitAPIMethod - used the method via conduit console with input ids : [1, 2] ManiphestTaskDetailController - viewed a task with and without associated projects; finished workflow creating a task with a parent
• ManiphestTransactionPreviewController - verified transaction preview showed up properly
• PhabricatorProjectBoardViewController - viewed a board
• PhabricatorProjectMoveController - moved a task around
• ManiphestRemarkupRule - made a task reference like {T123}
• ManiphestTaskQuery - executed a custom query for all tasks with page size of 2 and paginated through some tasks
• ManiphestTaskPHIDType - nothing random seems broken? =D

Call sites where had to do something funky

• ManiphestHovercardEventListener - loaded hover cards from task mentions