Page MenuHomePhabricator

Remove all edge events
ClosedPublic

Authored by epriestley on Jul 5 2014, 10:41 PM.
Tags
None
Referenced Files
F12823771: D9840.diff
Thu, Mar 28, 8:06 AM
Unknown Object (File)
Feb 13 2024, 5:52 PM
Unknown Object (File)
Feb 5 2024, 4:34 AM
Unknown Object (File)
Feb 5 2024, 4:34 AM
Unknown Object (File)
Feb 5 2024, 4:34 AM
Unknown Object (File)
Feb 5 2024, 4:34 AM
Unknown Object (File)
Feb 5 2024, 4:34 AM
Unknown Object (File)
Feb 4 2024, 4:37 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by joshuaspence.

Details

Summary

Ref T5245. These were a bad idea.

We no longer need actors for edge edits either, so remove those. Generally, edges have fit into the policy model as pure/low-level infrastructure, and they do not have any policy or capability information in and of themselves.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove all edge events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.

(Sorry about changing all of the dependencies around, was trying to make this diff arc patchable... but no luck)

This looks good... I just have one question.

src/infrastructure/edges/editor/PhabricatorEdgeEditor.php
24

Why does PhabricatorEdgeEditor no longer extend PhabricatorEditor?

epriestley edited edge metadata.
  • Add a note about low-levelness.

Oops -- shuffled away my inline, but the short version is that the base Editor class has setActor(), which has no effect here and is somewhat misleading (this editor applies below the policy layer).

This revision is now accepted and ready to land.Jul 7 2014, 4:21 AM
epriestley edited edge metadata.
  • Just pulling in rebase changes.
epriestley updated this revision to Diff 23928.

Closed by commit rP8cbfb49b4e93 (authored by @epriestley).