Page MenuHomePhabricator
Differential D9841

Use PhabricatorEdgeType strings when rendering transactions
ClosedPublic
Actions

Authored by epriestley on Jul 5 2014, 10:48 PM.
Tags
None
Referenced Files
F15505682: D9841.id23604.diff
Tue, Apr 15, 4:54 AM
F15500629: D9841.id23929.diff
Sun, Apr 13, 6:43 PM
F15478030: D9841.id23604.diff
Mon, Apr 7, 7:51 PM
F15469561: D9841.id23929.diff
Fri, Apr 4, 2:41 PM
F15469252: D9841.id23604.diff
Fri, Apr 4, 11:01 AM
F15462173: D9841.id23929.diff
Tue, Apr 1, 12:53 PM
F15462172: D9841.id23698.diff
Tue, Apr 1, 12:53 PM
F15462170: D9841.id23604.diff
Tue, Apr 1, 12:53 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T5245: Migrate Maniphest Projects to use edge infrastructure
Commits
Restricted Diffusion Commit
rPb32313cc85d8: Use PhabricatorEdgeType strings when rendering transactions
Summary

Ref T5245. This hooks up the translation/rendering methods added previously.

These are messy, but now extractable/translatable.

Test Plan

Viewed edge transactions and stories, saw correct strings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23604.Jul 5 2014, 10:48 PM
epriestley retitled this revision from to Use PhabricatorEdgeType strings when rendering transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.
epriestley added a task: T5245: Migrate Maniphest Projects to use edge infrastructure.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 5 2014, 10:48 PM
Harbormaster completed remote builds in B1543: Diff 23604.Jul 5 2014, 10:49 PM
joshuaspence added a parent revision: D9840: Remove all edge events.Jul 6 2014, 10:20 PM
joshuaspence requested changes to this revision.Jul 7 2014, 12:00 AM
joshuaspence edited edge metadata.
joshuaspence added inline comments.
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
599–600

As mentioned in D9837, I'm not convinced that there is a need to pass this in explicitly.

724

As above.

This revision now requires changes to proceed.Jul 7 2014, 12:00 AM
joshuaspence accepted this revision.Jul 7 2014, 4:23 AM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jul 7 2014, 4:23 AM
epriestley updated this revision to Diff 23698.Jul 10 2014, 12:26 PM
epriestley edited edge metadata.
  • getByConst() -> getByConstant()
Harbormaster completed remote builds in B1605: Diff 23698.Jul 10 2014, 12:28 PM
epriestley closed this revision.Jul 17 2014, 10:41 PM
epriestley updated this revision to Diff 23929.

Closed by commit rPb32313cc85d8 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
63 lines

Diff 23929

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility