Page MenuHomePhabricator
Differential D13909

Convert DifferentialDiff view to new PHUIDiffTableOfContentsListView
AbandonedPublic
Actions

Authored by epriestley on Aug 15 2015, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 6:00 PM
Unknown Object (File)
Wed, Sep 4, 11:29 AM
Unknown Object (File)
Sat, Aug 31, 2:23 PM
Unknown Object (File)
Sat, Aug 31, 12:38 PM
Unknown Object (File)
Thu, Aug 29, 4:06 PM
Unknown Object (File)
Sat, Aug 24, 8:56 AM
Unknown Object (File)
Sat, Aug 17, 9:42 PM
Unknown Object (File)
Aug 3 2024, 11:37 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2183: unify "table of contents" views between Differential and Diffusion
Summary

Ref T2183. Remove old Differential-specific stuff. Minor tweaks:

  • Hide coverage if no information is avialable.
  • Fix/tweak tooltips.
  • Share a little more code.
Test Plan

Viewed TOC in diffs and revisions.

Diff Detail

Repository
rP Phabricator
Branch
toc3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7645
Build 8328: [Placeholder Plan] Wait for 30 Seconds
Build 8327: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33572.Aug 15 2015, 6:02 PM
epriestley retitled this revision from to Convert DifferentialDiff view to new PHUIDiffTableOfContentsListView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T2183: unify "table of contents" views between Differential and Diffusion.
epriestley added a comment.Aug 15 2015, 6:04 PM

I'm generally pro-showing-empty-stuff-for-discovery, but I philosophically believe that the value of code coverage is dramatically overstated. Practically speaking, it's also not easy or reasonable to configure it for many projects.

chad accepted this revision.Aug 15 2015, 7:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 15 2015, 7:18 PM
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
epriestley abandoned this revision.Oct 4 2015, 3:17 PM

This ended up as part of rP81493993, I don't remember if that was on purpose or not.

chad added a comment.Oct 4 2015, 3:18 PM

boldmovecotton

Revision Contents
Changeset List

Diff 33572

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialDiffTableOfContentsView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

Loading...
Phabricator · Built by Phacility