Page MenuHomePhabricator

Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView
ClosedPublic

Authored by epriestley on Aug 15 2015, 5:54 PM.

Details

Summary

Ref T2183. Introduces a new View which can (in theory) unify the Revision, Diff and Commit table of contents views.

This has the same behavior as before, but accepts slightly more general primitives and parameters and has somewhat cleaner code.

I've made one intentinoal behavior change: removing the "Open All in Editor" button. I suspect this is essentially unused, and is a pain to keep around. We can look at restoring it if anyone notices.

Test Plan

Looked at a bunch of revisions, no changes from before.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 33568.Aug 15 2015, 5:54 PM
epriestley retitled this revision from to Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Aug 15 2015, 6:00 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 15 2015, 6:00 PM
This revision was automatically updated to reflect the committed changes.