HomePhabricator

Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView

Authored by epriestley.

Description

Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView

Summary:
Ref T2183. Introduces a new View which can (in theory) unify the Revision, Diff and Commit table of contents views.

This has the same behavior as before, but accepts slightly more general primitives and parameters and has somewhat cleaner code.

I've made one intentinoal behavior change: removing the "Open All in Editor" button. I suspect this is essentially unused, and is a pain to keep around. We can look at restoring it if anyone notices.

Test Plan: Looked at a bunch of revisions, no changes from before.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Differential Revision: https://secure.phabricator.com/D13908

Details

Event Timeline

CodeMouse92 raised a concern with this commit.Aug 16 2015, 11:17 PM
CodeMouse92 added a subscriber: CodeMouse92.

Unhandled Exception ("InvalidArgumentException")
Argument 2 passed to phutil_implode_html() must be of the type array, string given, called in /home/hawksnest/phab/phabricator/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php on line 277 and defined

See T9201: Unhandled Exception ("InvalidArgumentException") on random Differential

CodeMouse92 added inline comments.Aug 16 2015, 11:32 PM
/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php
277

Unhandled exception on this line for my install, for any Differential update since this change landed.

epriestley requested verification of this commit.Jan 27 2017, 5:22 PM

Resolved by work on T9201.

This commit now requires verification by auditors.Jan 27 2017, 5:22 PM
CodeMouse92 accepted this commit.Mar 4 2017, 1:40 AM
All concerns with this commit have now been addressed.Mar 4 2017, 1:40 AM