Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView
Auditedcb912d17352c
Actions

Description

Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView

Summary:
Ref T2183. Introduces a new View which can (in theory) unify the Revision, Diff and Commit table of contents views.

This has the same behavior as before, but accepts slightly more general primitives and parameters and has somewhat cleaner code.

I've made one intentinoal behavior change: removing the "Open All in Editor" button. I suspect this is essentially unused, and is a pain to keep around. We can look at restoring it if anyone notices.

Test Plan: Looked at a bunch of revisions, no changes from before.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Differential Revision: https://secure.phabricator.com/D13908

Details

Auditors

CodeMouse92

Provenance

epriestley	Authored on
epriestley	Pushed on Aug 15 2015, 6:43 PM

Reviewer

chad

Differential Revision

D13908: Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView

Parents

rPfca716d69969: More Ponder Answer polish

Branches

Unknown

Tags

Unknown

Tasks

T2183: unify "table of contents" views between Differential and Diffusion

Event Timeline

epriestley committed rPcb912d17352c: Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView (authored by epriestley).Aug 15 2015, 6:43 PM

epriestley added a task: T2183: unify "table of contents" views between Differential and Diffusion.

Unhandled Exception ("InvalidArgumentException")
Argument 2 passed to phutil_implode_html() must be of the type array, string given, called in /home/hawksnest/phab/phabricator/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php on line 277 and defined

See T9201: Unhandled Exception ("InvalidArgumentException") on random Differential

CodeMouse92 added inline comments.Aug 16 2015, 11:32 PM