Differential D17410

Build a Badges page for Profiles
ClosedPublic
Actions

Authored by chad on Feb 24 2017, 8:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 1:48 AM

	Unknown Object (File)
	Fri, Dec 20, 10:47 PM

	Unknown Object (File)
	Fri, Dec 20, 10:47 PM

	Unknown Object (File)
	Fri, Dec 20, 10:47 PM

	Unknown Object (File)
	Wed, Dec 18, 2:20 PM

	Unknown Object (File)
	Tue, Dec 17, 10:24 AM

	Unknown Object (File)
	Fri, Dec 13, 8:23 PM

	Unknown Object (File)
	Dec 9 2024, 3:52 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T12270: Unbeta Badges

Commits

rP80cccebca292: Build a Badges page for Profiles

Summary

Ref T12270. Moves badges into their own page and menu item. Capable of displaying hundreds of useful tokens of appreciation and dedication.

Test Plan

Test blank state, mobile, awards badges.

pasted_file (1×2 px, 411 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 24 2017, 8:57 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 24 2017, 8:57 PM

Harbormaster completed remote builds in B15762: Diff 41865.Feb 24 2017, 8:58 PM

chad edited the test plan for this revision. (Show Details)Feb 24 2017, 9:01 PM

good catto

pat pat pat

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
44–55	This was pre-existing, but this is pretty expensive ("Load every badge the user can view and edit") and won't scale particularly well -- maybe just always show the button? I'd guess users can mostly figure it out.

This revision is now accepted and ready to land.Feb 24 2017, 9:07 PM

Closed by commit rP80cccebca292: Build a Badges page for Profiles (authored by chad, committed by chad). · Explain WhyFeb 24 2017, 9:15 PM

This revision was automatically updated to reflect the committed changes.

chad added inline comments.Feb 24 2017, 9:16 PM

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
44–55	Maybe add a can_award capability?

I left it in for now, but will make a note to follow up with something better

It's at least now on a separate page vs. every profile.

There's no way to make "does any object exist which the user has X permission" on efficient in the general case. If an install has like 5,000 badges that query is going to take like 30 seconds to run no matter what.

You could do "limit 1" to make it less bad but the way "limit 1" works right now will actually make it way way worse.

Yeah. Not a big deal since it'll be a while before any install has enough badges for it to matter.

Not a big deal since it'll be a while before any install has enough badges for it to matter.

partycat

uhoh

d8b.png (1×1 px, 58 KB)

Revision Contents
Changeset List

Path

Size

resources/

celerity/

8 lines

src/

__phutil_library_map__.php

4 lines

applications/

badges/

controller/

PhabricatorBadgesAwardController.php

2 lines

people/

application/

PhabricatorPeopleApplication.php

2 lines

controller/

PhabricatorPeopleProfileBadgesController.php

137 lines

PhabricatorPeopleProfileController.php

7 lines

PhabricatorPeopleProfileManageController.php

2 lines

PhabricatorPeopleProfilePictureController.php

6 lines

PhabricatorPeopleProfileViewController.php

104 lines

engine/

PhabricatorPeopleProfileMenuEngine.php

10 lines

menuitem/

PhabricatorPeopleBadgesProfileMenuItem.php

59 lines

webroot/

rsrc/

css/

application/

project/

project-view.css

4 lines

phui/

5 lines

Diff 41866

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/badges/controller/PhabricatorBadgesAwardController.php

Loading...

src/applications/people/application/PhabricatorPeopleApplication.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php

Loading...

src/applications/people/menuitem/PhabricatorPeopleBadgesProfileMenuItem.php

Loading...

webroot/rsrc/css/application/project/project-view.css

Loading...

webroot/rsrc/css/phui/phui-badge.css

Loading...