Ref T12270. Moves badges into their own page and menu item. Capable of displaying hundreds of useful tokens of appreciation and dedication.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12270: Unbeta Badges
- Commits
- rP80cccebca292: Build a Badges page for Profiles
Test blank state, mobile, awards badges.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
good catto
pat pat pat
| src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php | ||
|---|---|---|
| 44–55 | This was pre-existing, but this is pretty expensive ("Load every badge the user can view and edit") and won't scale particularly well -- maybe just always show the button? I'd guess users can mostly figure it out. | |
| src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php | ||
|---|---|---|
| 44–55 | Maybe add a can_award capability? | |
Comment Actions
There's no way to make "does any object exist which the user has X permission" on efficient in the general case. If an install has like 5,000 badges that query is going to take like 30 seconds to run no matter what.
You could do "limit 1" to make it less bad but the way "limit 1" works right now will actually make it way way worse.
Comment Actions
Yeah. Not a big deal since it'll be a while before any install has enough badges for it to matter.
Comment Actions
Not a big deal since it'll be a while before any install has enough badges for it to matter.
