Touch up Badges emails
ClosedPublic
Actions

Authored by chad on Mar 2 2017, 3:21 AM.

Tags

None

Referenced Files

	F14842012: D17449.id41948.diff
	Sat, Feb 1, 8:19 PM

	Unknown Object (File)
	Fri, Jan 31, 1:57 AM

	Unknown Object (File)
	Mon, Jan 27, 10:51 AM

	Unknown Object (File)
	Thu, Jan 23, 8:55 PM

	Unknown Object (File)
	Thu, Jan 23, 8:55 PM

	Unknown Object (File)
	Thu, Jan 23, 8:54 PM

	Unknown Object (File)
	Thu, Jan 23, 5:01 AM

	Unknown Object (File)
	Wed, Jan 22, 11:25 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12270: Unbeta Badges

Commits

rP664d9fa3ed4c: Touch up Badges emails

Summary

Ref T12270. Adds the name of the badge to the subject, fixes the double description.

Test Plan

Edit lots of badges with and without descriptions, see good emails.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 2 2017, 3:21 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 2 2017, 3:21 AM

Harbormaster completed remote builds in B15852: Diff 41948.Mar 2 2017, 3:22 AM

epriestley accepted this revision.Mar 2 2017, 11:57 AM

This revision is now accepted and ready to land.Mar 2 2017, 11:57 AM

Closed by commit rP664d9fa3ed4c: Touch up Badges emails (authored by chad, committed by chad). · Explain WhyMar 2 2017, 2:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

editor/

PhabricatorBadgesEditor.php

15 lines

Diff 41961

View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Touch up Badges emailsClosedPublicActions