Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 17, 4:50 AM
Unknown Object (File)
Mon, Jan 27, 10:02 AM
Unknown Object (File)
Jan 23 2025, 8:57 PM
Unknown Object (File)
Jan 23 2025, 8:57 PM
Unknown Object (File)
Jan 23 2025, 8:57 PM
Unknown Object (File)
Jan 22 2025, 11:35 AM
Unknown Object (File)
Jan 21 2025, 11:53 AM
Unknown Object (File)
Jan 9 2025, 6:03 AM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.