Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Attached Files
Unknown Object (File)
Apr 13 2017, 2:27 PM
Unknown Object (File)
Apr 11 2017, 7:36 AM
Unknown Object (File)
Apr 10 2017, 1:42 PM
Unknown Object (File)
Apr 2 2017, 2:16 PM
Unknown Object (File)
Mar 10 2017, 12:41 PM
Unknown Object (File)
Mar 10 2017, 12:59 AM
F3887194: Screen Shot 2017-03-09 at 11.42.36 AM.png
Mar 9 2017, 7:43 PM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.