Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
F18825971: D17487.diff
Fri, Oct 24, 1:32 AM
F18825590: D17487.diff
Thu, Oct 23, 10:55 PM
F18822807: D17487.diff
Thu, Oct 23, 8:34 AM
F18783871: D17487.diff
Mon, Oct 13, 10:18 AM
F18755304: D17487.id42054.diff
Sun, Oct 5, 4:52 AM
F18733500: D17487.id.diff
Tue, Sep 30, 10:35 PM
F18581952: D17487.id.diff
Sep 11 2025, 7:16 AM
F18576777: D17487.diff
Sep 10 2025, 4:36 PM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.