Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
F15528677: D17487.id42054.diff
Tue, Apr 22, 1:12 PM
F15524413: D17487.id.diff
Mon, Apr 21, 7:48 AM
F15521895: D17487.diff
Sun, Apr 20, 4:18 PM
F15520152: D17487.diff
Sun, Apr 20, 3:54 AM
F15514071: D17487.id42053.diff
Fri, Apr 18, 12:07 AM
F15492836: D17487.id42053.diff
Sat, Apr 12, 6:49 PM
F15460625: D17487.id.diff
Tue, Apr 1, 12:31 AM
F15448314: D17487.id42053.diff
Fri, Mar 28, 4:09 AM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.