Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
F15438433: D17487.id42054.diff
Wed, Mar 26, 12:39 AM
F15434865: D17487.diff
Tue, Mar 25, 5:45 AM
F15430840: D17487.id42053.diff
Mon, Mar 24, 9:14 AM
F15423387: D17487.id42054.diff
Sat, Mar 22, 3:15 PM
F15419821: D17487.id.diff
Fri, Mar 21, 9:12 AM
F15418975: D17487.id42053.diff
Fri, Mar 21, 2:46 AM
F15418843: D17487.id42053.diff
Fri, Mar 21, 1:49 AM
F15417768: D17487.diff
Thu, Mar 20, 6:19 PM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.