Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
F19019852: D17487.id42053.diff
Sun, Nov 23, 4:07 PM
F19019480: D17487.id42053.diff
Sun, Nov 23, 2:39 PM
F18933412: D17487.id42054.diff
Nov 10 2025, 11:32 AM
F18915094: D17487.id42054.diff
Nov 9 2025, 7:28 AM
F18856880: D17487.id42053.diff
Nov 1 2025, 11:57 AM
F18842909: D17487.id.diff
Oct 28 2025, 7:37 PM
F18825971: D17487.diff
Oct 24 2025, 1:32 AM
F18825590: D17487.diff
Oct 23 2025, 10:55 PM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.