Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
F17835803: D17487.id.diff
Sat, Jul 26, 3:38 PM
F17826786: D17487.id42053.diff
Sat, Jul 26, 7:37 AM
F17808807: D17487.diff
Fri, Jul 25, 4:18 PM
F17758014: D17487.id.diff
Tue, Jul 22, 4:42 PM
F17755484: D17487.id42054.diff
Tue, Jul 22, 12:27 PM
F17736848: D17487.diff
Sun, Jul 20, 6:40 PM
F17711865: D17487.diff
Thu, Jul 17, 9:17 AM
F17691583: D17487.id42053.diff
Mon, Jul 14, 10:35 PM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.