Restrict all crumbs to 240 max width
ClosedPublic

Authored by chad on Feb 15 2017, 9:00 PM.

Details

Summary

Ref T12270. Any project, badge, dashboard, etc, that uses names in crumbs can over generate a long title. Restrict to a sane but generous width.

Test Plan

Make a project with a really long name, test various crumb layouts, boards, tasks, desktop, mobile.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chad created this revision.Feb 15 2017, 9:00 PM
epriestley accepted this revision.Feb 15 2017, 9:03 PM
This revision is now accepted and ready to land.Feb 15 2017, 9:03 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mon, Mar 6, 6:24 PM

What browser did you say you had issues with this on? Safari? I can't reproduce - tried Safari, Chrome, Firefox on Mac:

Safari, issue was with looking at user profiles where the crumb was short (like "alice").

(It would incorrectly render as "ali..." although there was plenty of room for it.)

chad added a comment.Mon, Mar 6, 6:28 PM

yeah I can't reproduce that either. are you on an older Safari?

Seems dependent on the name, let me see if I can get you a better idea of what the repro case is.

Bad:

  • hector
  • joedecker
  • Joey
  • ducksey

Good:

  • joseph
  • alice
  • jsmith
  • sloth
  • pidgeon
  • omnibus
  • tortise-list
  • nnn
  • UPPERCASE
  • chrome
  • saurus

Uh no idea, maybe ending in "r" or "y"? Probably something about font metrics?

chad added a comment.Mon, Mar 6, 6:34 PM

Yeah, I tried a dozen usernames, I can't reproduce it.

chad added a comment.Mon, Mar 6, 6:35 PM

oh ok, hector reproduces it.

"alice" is good, "alicy" is bad. "UPPERCASE" is good, "UPPERCASEy" is bad. So it depends on the last letter, I guess.