Page MenuHomePhabricator

Restrict all crumbs to 240 max width
ClosedPublic

Authored by chad on Feb 15 2017, 9:00 PM.
Tags
None
Attached Files
Unknown Object (File)
Mon, May 23, 6:25 AM
Unknown Object (File)
Apr 16 2017, 2:45 PM
Unknown Object (File)
Apr 15 2017, 4:51 AM
Unknown Object (File)
Mar 29 2017, 12:58 AM
Unknown Object (File)
Mar 10 2017, 11:40 PM
Unknown Object (File)
Mar 7 2017, 12:34 PM
F3771691: pasted_file
Mar 6 2017, 6:34 PM
F3771644: Screen Shot 2017-03-06 at 10.30.19 AM.png
Mar 6 2017, 6:30 PM
Subscribers

Details

Summary

Ref T12270. Any project, badge, dashboard, etc, that uses names in crumbs can over generate a long title. Restrict to a sane but generous width.

Test Plan

Make a project with a really long name, test various crumb layouts, boards, tasks, desktop, mobile.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 15 2017, 9:03 PM
This revision was automatically updated to reflect the committed changes.

What browser did you say you had issues with this on? Safari? I can't reproduce - tried Safari, Chrome, Firefox on Mac:

pasted_file (1×2 px, 317 KB)

Safari, issue was with looking at user profiles where the crumb was short (like "alice").

(It would incorrectly render as "ali..." although there was plenty of room for it.)

yeah I can't reproduce that either. are you on an older Safari?

Seems dependent on the name, let me see if I can get you a better idea of what the repro case is.

Bad:

  • hector
  • joedecker
  • Joey
  • ducksey

Good:

  • joseph
  • alice
  • jsmith
  • sloth
  • pidgeon
  • omnibus
  • tortise-list
  • nnn
  • UPPERCASE
  • chrome
  • saurus

Uh no idea, maybe ending in "r" or "y"? Probably something about font metrics?

Yeah, I tried a dozen usernames, I can't reproduce it.

pasted_file (956×1 px, 182 KB)

oh ok, hector reproduces it.

"alice" is good, "alicy" is bad. "UPPERCASE" is good, "UPPERCASEy" is bad. So it depends on the last letter, I guess.