Page MenuHomePhabricator

Remove obsolete Badges edge types
ClosedPublic

Authored by epriestley on Mar 24 2017, 9:03 PM.
Tags
None
Attached Files
Unknown Object (File)
Apr 16 2017, 7:51 PM
Unknown Object (File)
Apr 11 2017, 4:21 PM
Unknown Object (File)
Apr 11 2017, 7:19 AM
Unknown Object (File)
Apr 10 2017, 6:27 PM
Unknown Object (File)
Apr 10 2017, 5:35 PM
Unknown Object (File)
Apr 10 2017, 11:52 AM
Unknown Object (File)
Apr 10 2017, 11:51 AM
Unknown Object (File)
Apr 10 2017, 11:51 AM
Subscribers
None

Details

Summary

Ref T12270. These no longer have any callsites.

Test Plan

Used grep to search for each edge class constant, found no hits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

would this affect old migrations to Awards?

  • Wow! Also run arc liberate!

No, they use the constants explicitly, anticipating this change.

It will cause old award transactions to render "epriestley edited edges." or similar instead of "epriestley awarded this badge to chad.", but that's the only negative effect and I'm not planning to fix it since the app was beta when those awards happened.

(They also all happened more than a year ago.)

Or, at least, happened on a version of the codebase which is more than a year old

This revision is now accepted and ready to land.Mar 24 2017, 9:09 PM
This revision was automatically updated to reflect the committed changes.