Page MenuHomePhabricator

Improve behavior of inline comment highlight reticle for block diffs
ClosedPublic

Authored by epriestley on Sep 25 2019, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 7:37 AM
Unknown Object (File)
Sun, Mar 17, 4:36 PM
Unknown Object (File)
Feb 3 2024, 11:15 PM
Unknown Object (File)
Dec 18 2023, 6:39 PM
Unknown Object (File)
Dec 3 2023, 5:40 PM
Unknown Object (File)
Nov 30 2023, 4:25 AM
Unknown Object (File)
Nov 17 2023, 7:57 AM
Unknown Object (File)
Sep 27 2023, 3:56 PM
Subscribers
None

Details

Summary

Depends on D20834. Ref T13425. After the change from "th" to "td" for accessibility, the algorithm picks which cells it should highlight slightly improperly (it picks too many cells since it can no longer find the line numbers).

Ideally, it would probably highlight only the source content, but there isn't an easy way to do this right now. Settle for an incremental improvement for the moment.

Test Plan

Hovered over line numbers, saw a more accurate highlight area.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable