Page MenuHomePhabricator

Improve behavior of inline comment highlight reticle for block diffs
ClosedPublic

Authored by epriestley on Sep 25 2019, 8:25 PM.
Tags
None
Referenced Files
F18734061: D20835.id.diff
Tue, Sep 30, 10:47 PM
F18705560: D20835.diff
Sun, Sep 28, 11:56 AM
F18644964: D20835.id49666.diff
Fri, Sep 19, 6:33 AM
F18633356: D20835.diff
Tue, Sep 16, 8:08 PM
F18625133: D20835.diff
Mon, Sep 15, 10:03 PM
F18590964: D20835.id.diff
Sep 12 2025, 7:48 AM
F18570770: D20835.id49676.diff
Sep 10 2025, 4:07 AM
F18570767: D20835.id49666.diff
Sep 10 2025, 4:07 AM
Subscribers
None

Details

Summary

Depends on D20834. Ref T13425. After the change from "th" to "td" for accessibility, the algorithm picks which cells it should highlight slightly improperly (it picks too many cells since it can no longer find the line numbers).

Ideally, it would probably highlight only the source content, but there isn't an easy way to do this right now. Settle for an incremental improvement for the moment.

Test Plan

Hovered over line numbers, saw a more accurate highlight area.

Diff Detail

Repository
rP Phabricator
Branch
jupyter6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23493
Build 32287: Run Core Tests
Build 32286: arc lint + arc unit