Page MenuHomePhabricator

Improve behavior of inline comment highlight reticle for block diffs
ClosedPublic

Authored by epriestley on Sep 25 2019, 8:25 PM.
Tags
None
Referenced Files
F13082234: D20835.diff
Wed, Apr 24, 10:03 PM
Unknown Object (File)
Sun, Apr 21, 4:10 PM
Unknown Object (File)
Wed, Apr 17, 3:12 PM
Unknown Object (File)
Thu, Apr 11, 7:21 AM
Unknown Object (File)
Sun, Mar 31, 6:49 PM
Unknown Object (File)
Mar 21 2024, 7:37 AM
Unknown Object (File)
Mar 17 2024, 4:36 PM
Unknown Object (File)
Feb 3 2024, 11:15 PM
Subscribers
None

Details

Summary

Depends on D20834. Ref T13425. After the change from "th" to "td" for accessibility, the algorithm picks which cells it should highlight slightly improperly (it picks too many cells since it can no longer find the line numbers).

Ideally, it would probably highlight only the source content, but there isn't an easy way to do this right now. Settle for an incremental improvement for the moment.

Test Plan

Hovered over line numbers, saw a more accurate highlight area.

Diff Detail

Repository
rP Phabricator
Branch
jupyter6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23493
Build 32287: Run Core Tests
Build 32286: arc lint + arc unit