Paths

Table of Contentst

Differential D20465

Remove nearly all remaining references to "Autoclose"
ClosedPublic
Actions

Authored by epriestley on Apr 23 2019, 12:12 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"

Commits

rP8f43c773b832: Remove nearly all remaining references to "Autoclose"

Summary

Depends on D20464. Ref T13277. Broadly:

Move all the "should publish X" and "why aren't we publishing X" stuff to a separate class (PhabricatorRepositoryPublisher).
Rename things to be more consistent with modern terminology ("Publish", "Permanent Refs").

Test Plan

This could use some trial-by-fire on secure, but:

Grepped for all symbols.
Viewed various commits.
Reparsed commits.
Here's a commit with an explanation:

Diff Detail

Repository

rP Phabricator

Branch

audit8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22691
Build 31102: Run Core Tests
Build 31101: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 23 2019, 12:12 AM

Harbormaster completed remote builds in B22691: Diff 48819.Apr 23 2019, 12:14 AM

epriestley requested review of this revision.Apr 23 2019, 12:14 AM

epriestley added a child revision: D20466: Show "hold reasons" on commit page, not on "Edit" page.Apr 23 2019, 2:14 PM

amckinley accepted this revision.Apr 24 2019, 12:47 AM

This revision is now accepted and ready to land.Apr 24 2019, 12:47 AM

Closed by commit rP8f43c773b832: Remove nearly all remaining references to "Autoclose" (authored by epriestley). · Explain WhyApr 24 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

audit/

editor/

PhabricatorAuditEditor.php

6 lines

diffusion/

controller/

DiffusionCommitController.php

2 lines

editor/

DiffusionCommitEditEngine.php

30 lines

management/

DiffusionRepositoryBranchesManagementPanel.php

4 lines

view/

DiffusionBranchTableView.php

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

6 lines

PhabricatorRepositoryRefEngine.php

2 lines

query/

PhabricatorRepositoryPublisher.php

120 lines

storage/

PhabricatorRepository.php

169 lines

PhabricatorRepositoryCommitData.php

19 lines

worker/

PhabricatorRepositoryCommitOwnersWorker.php

3 lines

PhabricatorRepositoryPushMailWorker.php

4 lines

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

17 lines

Diff 48819

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

View Options

src/applications/repository/query/PhabricatorRepositoryPublisher.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

View Options

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Remove nearly all remaining references to "Autoclose"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48819

src/__phutil_library_map__.php

src/applications/audit/editor/PhabricatorAuditEditor.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

src/applications/diffusion/view/DiffusionBranchTableView.php

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

src/applications/repository/query/PhabricatorRepositoryPublisher.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Remove nearly all remaining references to "Autoclose"
ClosedPublic
Actions

Revision Contents
Changeset List