Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized

Authored by epriestley on Apr 17 2019, 2:31 AM.



Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 17 2019, 2:31 AM
epriestley requested review of this revision.Apr 17 2019, 2:32 AM
This revision is now accepted and ready to land.Apr 17 2019, 10:20 PM
This revision was landed with ongoing or failed builds.Apr 18 2019, 2:10 PM
This revision was automatically updated to reflect the committed changes.