Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
F12856866: D20440.id.diff
Fri, Mar 29, 10:04 AM
Unknown Object (File)
Wed, Mar 27, 1:58 AM
Unknown Object (File)
Wed, Mar 27, 1:58 AM
Unknown Object (File)
Wed, Mar 27, 1:58 AM
Unknown Object (File)
Wed, Mar 27, 1:58 AM
Unknown Object (File)
Fri, Mar 15, 8:00 PM
Unknown Object (File)
Feb 22 2024, 12:44 PM
Unknown Object (File)
Feb 3 2024, 10:14 PM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable