Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
F19538657: D20440.diff
Wed, Jan 21, 4:19 PM
F19529972: D20440.diff
Mon, Jan 19, 7:55 PM
F19520306: D20440.id.diff
Fri, Jan 16, 12:37 PM
F19517803: D20440.diff
Thu, Jan 15, 3:42 PM
F19244651: D20440.diff
Dec 22 2025, 1:05 AM
F18829161: D20440.diff
Oct 24 2025, 8:17 PM
F18824464: D20440.id.diff
Oct 23 2025, 3:51 PM
F18821688: D20440.diff
Oct 23 2025, 1:17 AM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Branch
chart4
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/fact/Chart.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 22615
Build 30993: Run Core Tests
Build 30992: arc lint + arc unit