Page MenuHomePhabricator

Modularize workboard column transactions
ClosedPublic

Authored by epriestley on Mar 14 2019, 3:22 PM.
Tags
None
Referenced Files
F13265959: D20286.diff
Tue, May 28, 7:27 AM
F13264894: D20286.id.diff
Mon, May 27, 11:07 PM
F13255092: D20286.diff
Sat, May 25, 4:24 AM
F13240536: D20286.id48425.diff
Wed, May 22, 2:55 PM
F13233719: D20286.diff
Tue, May 21, 2:31 AM
F13217732: D20286.diff
Sat, May 18, 7:45 AM
F13211913: D20286.diff
Fri, May 17, 6:13 AM
F13209565: D20286.id48489.diff
Fri, May 17, 12:57 AM
Subscribers
None

Details

Summary

Depends on D20279. Ref T5474. Modernize these transactions before I add a new "TriggerTransaction" for setting triggers.

Test Plan

Created a column. Edited a column name and point limit. Hid and un-hid a column. Grepped for removed symbols.

Diff Detail

Repository
rP Phabricator
Branch
trigger2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22361
Build 30595: Run Core Tests
Build 30594: arc lint + arc unit

Event Timeline

src/applications/project/controller/PhabricatorProjectColumnEditController.php
96

This fixes a bug where this workflow didn't actually enforce the requirement that columns have a name.

amckinley added inline comments.
src/applications/project/xaction/column/PhabricatorProjectColumnLimitTransaction.php
40

For consistency, "changed the point limit".

src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php
23

"unhid this column"

27

"hid this column"

48

This is just going to be "0, 1"; maybe don't even bother to show it?

This revision is now accepted and ready to land.Mar 18 2019, 6:57 PM
src/applications/project/xaction/column/PhabricatorProjectColumnStatusTransaction.php
48

I think it'll be real strings some day. Showing it is mostly for the benefit of API callers, since the internal constants may not always be obvious.

This revision was automatically updated to reflect the committed changes.